Skip to content

Conversation

tetsuharuohzeki
Copy link
Contributor

Fix #84

@benlesh
Copy link
Member

benlesh commented Aug 10, 2015

Thanks! I'll check this out after a while unless someone else gets to it. I'm on vacation this week.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saneyuki thanks for the PR! Would you mind updating this file to pull in the module for the operator you're relying on here, like concat does? Since we're aiming for complete modularity, we can't assume concat will exist on the ScalarObservable prototype. I'd be satisfied with this PR if you pulled in either of the concat or merge modules, it's your choice. Thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd also be great if you changed this to use the ScalarObservable constructor, instead of just, since ScalarObservable isn't guaranteed to have just statically defined either.

@tetsuharuohzeki
Copy link
Contributor Author

@trxcllnt thank you for your review!. I pushed the fixup commit.

@trxcllnt
Copy link
Member

@saneyuki thanks! lgtm.

@benlesh
Copy link
Member

benlesh commented Aug 13, 2015

There's no way you could know this, because we don't have contribution guidelines, but I'd really like it if you could flatten your commits and change the commit message to: `feat(operator): implement startWith"

The easiest way to do this would be an interactive rebase. git rebase -i HEAD~2 then you'd fixup the second entry, and reword the first. If you need any additional help, let me know and I'm happy to assist.

Otherwise, LGTM... let me know when you've got those changes pushed and I'll merge it in.

Thanks again!

@tetsuharuohzeki
Copy link
Contributor Author

@Blesh

okay! I squashed my changesets & change the message to feat(operator): implement startWith().

@benlesh
Copy link
Member

benlesh commented Aug 13, 2015

PR merged with commit 1f36d99

@benlesh benlesh closed this Aug 13, 2015
@tetsuharuohzeki tetsuharuohzeki deleted the startwith branch August 13, 2015 17:08
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants