Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate all SSE classes in io.reactivex.netty.protocol.text.sse #209

Closed
NiteshKant opened this issue Aug 19, 2014 · 3 comments
Closed

Deprecate all SSE classes in io.reactivex.netty.protocol.text.sse #209

NiteshKant opened this issue Aug 19, 2014 · 3 comments
Labels
Deprecation
Milestone
0.3.17

Comments

@NiteshKant
Copy link
Member

In relation to issue #205 we need to first deprecate these classes in the io.reactivex.netty.protocol.text.sse package so that we can delete some and move the other to the io.reactivex.netty.protocol.http.sse package in the next release.
@NiteshKant NiteshKant added this to the 0.3.12 milestone Aug 19, 2014
@NiteshKant NiteshKant self-assigned this Aug 19, 2014
@gorzell
Copy link

gorzell commented Aug 19, 2014

I have this mostly done.

What I did was move the existing classes and replaced them with proxies that extend the originals. These proxies are marked as deprecated.

@NiteshKant
Copy link
Member Author

@gorzell sounds good, I will wait for your PR then. In case I need to release 0.3.12 sooner, will punt this to 0.3.13

@NiteshKant NiteshKant removed their assignment Aug 19, 2014
@gorzell
Copy link

gorzell commented Aug 19, 2014

I'll try to wrap this up today. It has been a bit tricky because some tests fail sporadically for me and the Context tests still fail every time.

@gorzell gorzell mentioned this issue Aug 19, 2014
Closed
@NiteshKant NiteshKant modified the milestones: 0.3.12, 0.3.13 Aug 20, 2014
@NiteshKant NiteshKant modified the milestones: 0.3.13, 0.3.14 Sep 7, 2014
@NiteshKant NiteshKant modified the milestones: 0.3.14, 0.3.15 Sep 19, 2014
@NiteshKant NiteshKant modified the milestone: 0.3.15 Oct 23, 2014
NiteshKant pushed a commit to NiteshKant/RxNetty that referenced this issue Nov 3, 2014
Fixes ReactiveX#205 ReactiveX#209 ReactiveX#220 ReactiveX#222
3ae9b69 
ReactiveX#205 (Move SSE related classes to http): This is a new implementation of SSE for some optimizations and spec compliance.
ReactiveX#209 (Deprecated all SSE classes in text pkg): SSE is only applicable to HTTP.
ReactiveX#220 (SSE Output confusion): Default case only emits data event.
ReactiveX#222 (Improved SSE API): Better construction semantics.
ReactiveX#30 (Optimized SSE decoder): Rewrite of the existing decoder.
This was referenced Nov 3, 2014
Merged
Closed
Closed
@NiteshKant NiteshKant modified the milestone: 0.3.17 Nov 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Deprecation
Projects
None yet
Milestone
0.3.17
Development

No branches or pull requests
2 participants
@NiteshKant @gorzell