Refactoring #19
Merged
Refactoring #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
January 18, 2014 12:43
…at we do not need. Fixed a compilation error due to package name changes.
The major changes are these: 1) Have a single client & server implementation that can be used for all connection oriented transport & application protocols. 2) Renamed the Protocolhandler to NettyPipelineConfigurator as it does not do any protocol handing per se, it just configures the pipeline. ProtocolHandler was a misnomer. 3) The Client & Server has only 2 Rx specific handlers on top of the netty pipeline, one for connection lifecycle & another for converting netty's events to Rx Observer callbacks. The following are the TODOs as of now: 1) Http implementation is not at all complete. Although the pipeline configurators are as we want them. 2) Groovy examples needs to be fixed. 3) Http unit tests are commented out as the client is going to change drastically.
TODO: 1) Fix HTTP unit tests. 2) Fix SSE server/client interaction. The server does not seem to be publishing the correct SSE data, the SSEDecoder does not publish events. 3) Fix groovy examples. 4) Add read timeout handler support. 5) HttpClient may create a request eagerly for pooled connections (which are not supported as of now)
1) The SSEInboundHandler was not passing any unknown messages through it. 2) The SSE encoder was putting a single new line instead of two to indicate end of message. 3) Introduced the read timeout functionality. TODO: Remove the timeout handler.
1) Extracted an interface for the client, which will help us implement pooled, non-pooled, pooled per route etc. type of clients. 2) Cleaned up the PipelineConfigurators to remove "handler" reference & also clarified the names to better suit the behavior. Added few more factory methods.
|
I'll just merge the pull request so I can start using the updated API in Mantis. |
This was referenced Jan 28, 2014
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following were the major design goals in this refactoring:
TODO: