Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move docs and requirements to match better with read-the-docs. #336

Merged
merged 1 commit into from
Apr 1, 2019
Merged

Move docs and requirements to match better with read-the-docs. #336

merged 1 commit into from
Apr 1, 2019

Conversation

dbrattli
Copy link
Collaborator

@dbrattli dbrattli commented Apr 1, 2019

No description provided.

@dbrattli dbrattli mentioned this pull request Apr 1, 2019
Merged
@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.005% when pulling 0a7a107 on feature/readthedocs into 49277de on master.

erikkemperman
erikkemperman approved these changes Apr 1, 2019
View reviewed changes
Copy link
Collaborator

@erikkemperman erikkemperman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I will have to rebase the other PR, but that's no problem.

jcafhe
jcafhe approved these changes Apr 1, 2019
View reviewed changes
Copy link
Collaborator

@jcafhe jcafhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too, relative to https://docs.readthedocs.io/en/stable/guides/specifying-dependencies.html?highlight=dependencies

@erikkemperman
Copy link
Collaborator

I restarted the failing Travis build (see #338) to make everything green here. Since I will need to rebase the other PR, I will go ahead and merge this now.

@erikkemperman erikkemperman merged commit 00f26a8 into master Apr 1, 2019
@erikkemperman
Copy link
Collaborator

Succes!
https://rxpy.readthedocs.io/en/latest/

@dbrattli
Copy link
Collaborator Author

dbrattli commented Apr 1, 2019

Nice! Still an error for the Latex build. Not sure why RTD does that. Maybe to produce a PDF? #339

@erikkemperman erikkemperman deleted the feature/readthedocs branch April 1, 2019 08:38
@erikkemperman erikkemperman restored the feature/readthedocs branch April 1, 2019 08:38
@dbrattli dbrattli deleted the feature/readthedocs branch June 10, 2019 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikkemperman erikkemperman erikkemperman approved these changes

@jcafhe jcafhe jcafhe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dbrattli @coveralls @erikkemperman @jcafhe