Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align docs with current example code #387

Merged
merged 1 commit into from
May 22, 2019
Merged

Align docs with current example code #387

merged 1 commit into from
May 22, 2019

Conversation

dbrattli
Copy link
Collaborator

Aligning the docs with the current example code. We can discuss how things should be but we should try to have a consistent style in both docs and examples.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.649% when pulling 20abfe8 on feature/doc-fixes into e37cadf on master.

@dbrattli dbrattli requested a review from jcafhe May 21, 2019 20:24
jcafhe
jcafhe approved these changes May 22, 2019
View reviewed changes
Copy link
Collaborator

@jcafhe jcafhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I agree with you about the style.

@dbrattli dbrattli merged commit 9c9a6de into master May 22, 2019
@dbrattli
Copy link
Collaborator Author

Thanks for reviewing. Let's keep iterating on the docs ...

@dbrattli dbrattli deleted the feature/doc-fixes branch June 10, 2019 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MainRo MainRo MainRo approved these changes

@jcafhe jcafhe jcafhe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dbrattli @coveralls @MainRo @jcafhe