Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version numbers in info.plist are not consistent with current tag #707

Closed
amarcadet opened this issue May 24, 2016 · 3 comments
Closed

Version numbers in info.plist are not consistent with current tag #707

amarcadet opened this issue May 24, 2016 · 3 comments

Comments

@amarcadet
Copy link

Current tag is 2.5.0 and current info.plist files are 2.0.0.
@kzaher
Copy link
Member

kzaher commented May 24, 2016

Hi @amarcadet ,

good point. I think we would want to add check for that to ./scripts/pre-release-tests.sh.

kzaher added a commit that referenced this issue May 31, 2016
@kzaher
Improves version checking logic. #707
52c6e6d
@kzaher
Copy link
Member

kzaher commented Jun 1, 2016

Pushed fix for this yesterday.

This should be fixed in develop branch, and we'll update those versions with next release.

@kzaher kzaher closed this as completed Jun 1, 2016
@amarcadet
Copy link
Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amarcadet @kzaher