Fix CLLocationManager extension example #1208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
17 tasks
kzaher
reviewed
Apr 21, 2017
| } | ||
|
|
||
| public func locationManager(_ manager: CLLocationManager, didUpdateLocations locations: [CLLocation]) { | ||
| didUpdateLocationsSubject.onNext(locations) |
There was a problem hiding this comment.
This needs to forward call to _forwardToDelegate?.locationManager(manager, didUpdateLocations: locations)
There was a problem hiding this comment.
@kzaher Should it do that in addition to publishing to the subject, or instead of, or should it only publish to the subject if _forwardToDelegate is nil?
There was a problem hiding this comment.
@phlippieb it should do both.
- publish to publish subject -> for observing
- forward it to forwarding delegate -> because of forwarding delegate definition
There was a problem hiding this comment.
@kzaher Roger that. Updated.
| } | ||
|
|
||
| public func locationManager(_ manager: CLLocationManager, didFailWithError error: Error) { | ||
| didFailWithErrorSubject.onNext(error) |
Generated by 🚫 Danger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces PR 1027, which targeted master instead of develop.
Should fix #1136. This uses a similar method as RxScrollViewDelegateProxy.swift.