-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added reactive wrapper for WKWebView #432
Conversation
Hi @MokuMOku , I think you extensions totally make sense. There are just 2 problems. The first one is that I'm not sure we would want to include them inside RxCocoa project since they are WebKit extensions.
The other is that I haven't found that those properties are officially KVO compatible, which means that some other notification mechanism should probably be implemented to observe changes. If you are interested, I can add you to RxSwiftCommunity and we can start RxWebKit extensions project there. I understand if it's not something you are interested in or don't have time for. |
Hi @kzaher , I could import I am interested in RxWebKit! |
Hi @MokuMOku , First of all, I've sent you an invite to join RxSwiftCommunity. I've been thinking about this PR. I'm still unsure how would we organize all other frameworks there like:
Maybe separating them into their own repositories would be too much maintenance. Probably the simplest would be to create a single repository that contains pods (and Carthage targets) for all remaining apple frameworks. Something like RxDarwin, or RxApple, or something else ... In that way we could set up build server and integration tests for only one more repository. As far as for KVO property observing, I don't think you can use KVO observing to officially observe them but you'll would need to use delegates instead. These properties are KVO compliant:
For these we don't know:
I believe that |
Hi @kzaher , Thank you for your invitation. There are some repos in RxSwiftCommunity and I will add a new repo. I also feel uneasy that we clone unnecessary framework if we have only one repository. If we resolve the point, I agree your plan. As far as KVO observing, I think you are right. I will try to use |
Hi @MokuMOku , I believe you should be able to create new repository under RxSwiftCommunity. You can chose a name for this. Maybe You can check out how to set up CocoaPods and Carthage integration in one of the other sibling projects. I know it works for RxDataSources, but probably works for others as well. And that's it :) It would be nice to add a small example app together with |
Hi @kzaher , Thank you for your help. I will create I also try to make it CocoaPods and Carthage compatible using I close this Pull Request. |
I want to observe
WKWebView
's read only properties.