Add onErrorClose #371
Open
Add onErrorClose #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Extension Methods phase 1
- Introduce ObservableExtensions
- Move all Rx operators from Observable to *Extension
- Remove all "wrapper" methods from Observable
- Default to Stream Implementations
- Keep constructors on Observable class
- Remove Exported Futures & Tests
- AsObservable Future no longer provides utility
- Min and Max are easily inlined
- Remove OfType
- Remove concatMap
- Add documentation for all Stream extensions
Codecov Report
@@ Coverage Diff @@
## master #371 +/- ##
==========================================
- Coverage 93.35% 93.14% -0.21%
==========================================
Files 59 60 +1
Lines 2016 2057 +41
==========================================
+ Hits 1882 1916 +34
- Misses 134 141 +7 |
brianegan
force-pushed
the
extension-methods
branch
from
75161ba
to
a1c8235
Compare
|
Nice job guys!! Any Idea when we getting it in stable? |
|
Heya @shinayser -- a bit of a busy time for me with holidays coming up. I'll hopefully get to it over the break, but no promises. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
onErrorCloseto theonErrorResumeextension methods. Fixes #369