This repository has been archived by the owner on Oct 1, 2018. It is now read-only.
fix(accessibility): Changed colors of links and operator header copy #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added alternative text to the GitHub logo in the header. n/a
Added alternative text to the combineAll image. n/a
…mage. Added JS to generate the alt text for the combineAll image. n/a
…chrisdemars-img-alt
…rxjs-docs into chrisdemars-img-alt
Chrisdemars img alt
Change the link color to a darker blue to fix some of the color contrast issues. no breaking changes
Changed copy color to white in operater header to fix color contrast issues. no breaking changes
Codecov Report
@@ Coverage Diff @@
## master #217 +/- ##
=======================================
Coverage 74.49% 74.49%
=======================================
Files 10 10
Lines 149 149
Branches 7 7
=======================================
Hits 111 111
Misses 38 38Continue to review full report at Codecov.
|
sumitarora
approved these changes
Dec 20, 2017
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| $operator-border: #f3f3f3; | |||
| $operator-active: #62757f; | |||
| $link-color: #2196f3; | |||
| $link-color:#0a6fc2; | |||
There was a problem hiding this comment.
Not a big deal, but isn't better to keep the space between colon and #? Just a cosmetic point
|
Ooooh that is my fault. I thought I put the space in, sorry.
…On Wed, Dec 20, 2017 at 2:25 PM, Gois ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/app/operators/_operator-theme.scss
<#217 (comment)>:
> @@ -2,7 +2,7 @@
$operator-border: #f3f3f3;
$operator-active: #62757f;
-$link-color: #2196f3;
+$link-color:#0a6fc2;
Not a big deal, but isn't better to keep the space between colon and #?
Just a cosmetic point
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#217 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGfAcqMQ-RKp4qI1nLqDJw8ZTzcJh6LMks5tCV4PgaJpZM4RIw5S>
.
|
Glad to help |
…theme scss partial. Added space between prop and val in the operator theme scss partial. no breaking changes
|
I put that fix in @guilhermejcgois |
guilhermejcgois
approved these changes
Dec 21, 2017
|
@chrisdemars - Nice job. Can you please squash your commits and push ? Thank you ! |
|
I don't know how to squash commits @ashwin-sureshkumar. I have never had to do that before. |
|
Thanks for the merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the colors of the links to a darker blue and the operator header copy to white to fix color contrast errors.