fix(fromFetch): don't abort if fetch resolves #4742
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR rearranges an existing test so that the expectations are performed after the complete - and subsequent unsubscribe - are finished. The rearranged test fails.
It also adds a flag to the
fromFetch
implementation so thatabort
is not called in the teardown if the promise returned byfetch
has resolved.This fixes the problem, but it also highlights a problem with the implementation: streamed data obtained using
fromFetch
cannot be aborted, as theAbortController
passed to fetch also aborts the promises returned fromtext
andjson
, etc.Related issue (if exists): #4739