fix(startWith): accepts N arguments and returns correct type #5247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benlesh
force-pushed
the
update-startWith-types
branch
from
1f565f3
to
0deb14b
Compare
|
Note to self: look at #5157 when reviewing this. |
|
ping @cartant |
cartant
approved these changes
Jan 29, 2020
| const r4 = of(a).pipe(startWith(b, c, d, e)); // $ExpectType Observable<A | B | C | D | E> | ||
| const r5 = of(a).pipe(startWith(b, c, d, e, f)); // $ExpectType Observable<A | B | C | D | E | F> | ||
| const r6 = of(a).pipe(startWith(b, c, d, e, f, g)); // $ExpectType Observable<A | B | C | D | E | F | G> | ||
| const r7 = of(a).pipe(startWith(b, c, d, e, f, g, h)); // $ExpectType Observable<A | B | C | D | E | F | G | H> | ||
| }); | ||
|
|
||
| it('should infer correctly with only a scheduler', () => { |
There was a problem hiding this comment.
Minor nit: test description is now out-of-date
src/internal/operators/startWith.ts
Outdated
| */ | ||
| export function startWith<T, D>(...array: Array<T | SchedulerLike>): OperatorFunction<T, T | D> { | ||
| const scheduler = array[array.length - 1] as SchedulerLike; | ||
| export function startWith<T, D>(...values: Array<T | SchedulerLike>): OperatorFunction<T, T | D> { |
There was a problem hiding this comment.
I see that #5157 has been merged, so I'm guessing the change in that PR will be picked up once this is rebased.
- Improves documentation a bit - Updates type tests NOTE: Calls with more than 7 arguments that have a Scheduler at the end will return the wrong time. This is consider a corner case and low-risk BREAKING CHANGE: `startWith` will return incorrect types when called with more than 7 arguments and a scheduler. Passing scheduler to startWith is deprecated
benlesh
force-pushed
the
update-startWith-types
branch
from
0deb14b
to
a6b9ab8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Calls with more than 7 arguments that have a Scheduler at the end will return the wrong time. This is consider a corner case and low-risk
BREAKING CHANGE:
startWithwill return incorrect types when called with more than 7 arguments and a scheduler. Passing scheduler to startWith is deprecated