fix(ReplaySubject): don't buffer next if stopped #5696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oh, FFS, now I've done it.
benlesh
approved these changes
Sep 6, 2020
🤣 |
benlesh
pushed a commit
that referenced
this pull request
Sep 6, 2020
* test(ReplaySubject): add failing tests * fix(ReplaySubject): don't buffer next if stopped * chore: remove VSCode-added lodash import Oh, FFS, now I've done it.
|
Merged into |
|
published with |
This was referenced Mar 6, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes a bug in
ReplaySubject- demonstrated in failing tests - in which nexted values were buffered after the subject was stopped (by acompleteorerrorcall).Related issue (if exists): None