fix: use empty object type in combineLatest/forkJoin sigs #5832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartant
force-pushed
the
empty-object-type
branch
from
fca6b0f
to
f2d174d
Compare
benlesh
approved these changes
Oct 25, 2020
|
LGTM. Needs rebased. You can merge when ready. |
cartant
force-pushed
the
empty-object-type
branch
from
ac1b83d
to
38a36f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds failing tests to show that the current signatures for
combineLatestandforkJoindepend upon the excess-properties behaviour that TypeScript applies to object literals and fixes the problem by using a proper empty-object type in the function signatures.See this comment.
Related issue (if exists): None