chore: update docs app to Angular v15 #7238
Open
+20,442
−18,970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LcsGa
reviewed
May 23, 2023
Comment on lines
+31
to
33
| this.location.subscribe((state) => { | ||
| return this.urlSubject.next(state.url || ''); | ||
| }); |
There was a problem hiding this comment.
Suggested change
| this.location.subscribe((state) => { | |
| return this.urlSubject.next(state.url || ''); | |
| }); | |
| this.location.subscribe((state) => return this.urlSubject.next(state.url ?? '')); |
There was a problem hiding this comment.
@LcsGa Did you mean this?
Suggested change
| this.location.subscribe((state) => { | |
| return this.urlSubject.next(state.url || ''); | |
| }); | |
| this.location.subscribe((state) => this.urlSubject.next(state.url || '')); |
There was a problem hiding this comment.
Oh indeed! Forget to remove the return keyboard plus I would have used the nullish coalescing operator ?? instead of ||
LcsGa
reviewed
May 23, 2023
| const search = Object.keys(params).reduce((acc, key) => { | ||
| const value = params[key]; | ||
| return (value === undefined) ? acc : | ||
| acc += (acc ? '&' : '?') + `${encodeURIComponent(key)}=${encodeURIComponent(value)}`; | ||
| return value === undefined ? acc : (acc += (acc ? '&' : '?') + `${encodeURIComponent(key)}=${encodeURIComponent(value)}`); |
There was a problem hiding this comment.
Suggested change
| return value === undefined ? acc : (acc += (acc ? '&' : '?') + `${encodeURIComponent(key)}=${encodeURIComponent(value)}`); | |
| return value === undefined ? acc : (acc + (acc ? '&' : '?') + `${encodeURIComponent(key)}=${encodeURIComponent(value)}`); |
= is not needed since you already return the result which will be the new acc
There was a problem hiding this comment.
Which needs to become new acc, therefore it is needed 🙂
Anyways, I didn't change anything in this PR, a lot of fixes here are just Prettier uglifying things (I don't like Prettier), therefore, if it worked before, I wouldn't change it now.
LcsGa
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Update docs app to Angular v15
Related issue (if exists):
None