Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS cli option #113
iOS cli option #113
Changes from 9 commits
135b8e2
592973c
3aa1620
f5cc567
ae0b29b
8b25dc2
034c908
98102c9
95e6e4c
63872bd
1ed1259
2ed7d5d
7d88e9c
7e0d414
df2b25d
34e090c
1bcccda
5cfd946
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't use
unwrap()
in runtime code; I try to reserve it for tests only.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha, would this be better?
or we could reflow the logic so it goes ios, macos, error in the match
and we could always swap out the "Could not get a filename" with just a plain old error like so
or returning it "macOS" style, which is the path from the internal iPhone file system
again I'm not entirely sure how you want the program to handle it or what syntactic style you prefer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the logic for the iOS parsing should be split out somewhere so that it can be tested separately.
I think this whole block will be a lot cleaner once we use an enum instead of a
bool
here, so I will wait to review it until that changes.