redis : fixed ip version indistinguishability #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudarshan-reddy
assigned sudarshan-reddy and sivachandran and unassigned sudarshan-reddy
sivachandran
suggested changes
Dec 27, 2016
| } else { | ||
| return ipv4 | ||
| } | ||
| case bool: |
There was a problem hiding this comment.
instead of doing this, we could directly use ipv4 and upv6 strings in the ScrapeSwarm function like below
...
var ipType string = ipv4
if v6 {
ipType = ipv6
}
| @@ -84,34 +89,53 @@ func addKeyPrefix(namespacePrefix string, command string) string { | |||
| return command | |||
| } | |||
|
|
|||
| func getIPType(ip interface{}) string { | |||
| @@ -84,34 +89,53 @@ func addKeyPrefix(namespacePrefix string, command string) string { | |||
| return command | |||
There was a problem hiding this comment.
remove the function and directly concatenate the keyPrefix with "seeder" and "leecher"
sivachandran
approved these changes
Dec 27, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a pseudo decorator to seeder and leecher prefixes to distinguish between ip6 and ip4 peers.