-
-
Notifications
You must be signed in to change notification settings - Fork 153
Conversation
Thanks for doing this (and catching the linked-state deprication!). Not sure what's up with the tests failing. Am having a look into that now |
@RealOrangeOne no problem! I'm not sure what's up with the tests either. Looks like it's only on v4, but looks like a problem that's been going on for a while (look at the previous build logs). |
@@ -42,22 +42,22 @@ | |||
"eslint-plugin-react": "=5.1.1", | |||
"eslint-plugin-react-native": "=1.0.2", | |||
"mocha": "=2.5.3", | |||
"react": "=15.1.0", | |||
"react": "=15.4.0", | |||
"react-native": "^0.27.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like tests are breaking here. Please change to >=0.27.0. Not sure why this was only happening in node 4 though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated 👍
"react-addons-pure-render-mixin": "^15.4.0", | ||
"react-addons-test-utils": "^15.4.0", | ||
"react-addons-update": "^15.4.0", | ||
"react-dom": "^15.4.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to explicitly state a dependancy on react-dom? Surely the addons libraries will handle installing this for us?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The addons specify a peerDependency so they don't install react-dom
unfortunately!
seems the reason the tests are failing is because react-native doesnt yet support react@15.4.0, so merging this would likely break the install for a lot of people |
@RealOrangeOne looks like you might be right. v0.38.0-rc.0 seems to have support for v15.4.0, and RN has a fortnightly release cycle, so I'd expect compatibility to be available in a few days' time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending next stable release of react-native
"react": "^15.4.0", | ||
"react-native": ">=0.27.0" | ||
"react-native": "0.38.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you leave this as a loose dependancy, so it upgrades automatically. Will help with tests
@@ -28,22 +28,22 @@ | |||
}, | |||
"homepage": "https://github.com/RealOrangeOne/react-native-mock#readme", | |||
"devDependencies": { | |||
"babel": "=6.5.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason you removed the =
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a read through the docs and it isn't necessary to include the =
, this is done automatically by NPM
https://github.com/npm/node-semver#versions
A leading "=" or "v" character is stripped off and ignored.
Hey FYI @RealOrangeOne the NPM package still needs version bumping to get this fix out :) |
Please release a new version on NPM. Thanks @RealOrangeOne |
Yup. Currently blocking my project and I'm having to workaround right now! |
Released v0.2.9 |
Since React 15.4.0,
react-addons-perf
looks toreact-dom
. This PR updates dependency versions and removes thereact-addons-linked-state
dependency, which is now deprecated.Fixes #111.