Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in Tb128 - popup for restricted features: notification leads to exception + icon not displayed #486

Closed
RealRaven2000 opened this issue Aug 4, 2024 · 2 comments
Assignees
Labels

Comments

@RealRaven2000
Copy link
Owner

RealRaven2000 commented Aug 4, 2024

This is caused by the function NotificationBox.appendNotification() having been converted to async in mozilla-central 128 (Firefox' codebase)

Uncaught (in promise) TypeError: newNotification.messageImage is undefined
    popupRestrictedFeature chrome://quickfolders/content/quickfolders-util.js:415
    onSkipFolder chrome://quickfolders/content/quickfolders-interface.js:541
    oncommand about:3pane:1
quickfolders-util.js:415:11

For example, when the user does something like "Skip unread folder", without a QF license, they get a notification such as the on shown below:

image

The QuickFolders icon should also be displayed on the left of the notification. It is also possible that a function doesn't fully execute after the exception is thrown.

@RealRaven2000 RealRaven2000 self-assigned this Aug 4, 2024
@RealRaven2000
Copy link
Owner Author

Here is a quick fix:

QuickFolders-mx-6.6.2pre2.zip

shows the correct notification and throws no more exceptions:

image


To try the version above download zip file and drag the file into Thunderbird Add-ons Manager (do not extract contents, it won't install like that)

RealRaven2000 added a commit that referenced this issue Aug 7, 2024
- turned callers of `notifyBox.appendNotification` to async
- fix notification bar layout for 128
RealRaven2000 added a commit that referenced this issue Aug 11, 2024
@RealRaven2000
Copy link
Owner Author

Implemented in 6.7, Published 17/08/2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant