Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Branding: Generate branded image resources from a smaller set of golden images #15

Open
trflynn89 opened this issue Jun 29, 2022 · 0 comments
Open

Branding: Generate branded image resources from a smaller set of golden images #15

trflynn89 opened this issue Jun 29, 2022 · 0 comments
Labels
branding This is a Rebel branding issue.

Comments

@trflynn89
Copy link

There are many images under the branding root directory //rebel/branding/rebel for various platforms, formats, etc. It's a pain to have to create these, and a hurdle new forks have to go through to get their logos into the browser.

So many of these are just duplicates in various sizes and formats. Can we create a script to generate these images? This would allow new forks to maintain a much smaller set of assets.
@trflynn89 trflynn89 added the branding This is a Rebel branding issue. label Jun 29, 2022
trflynn89 pushed a commit that referenced this issue Feb 28, 2023
@joedow-42
Add feature to allow boosting the capture rate when input is injected
2a2ab63 
This is an experimental feature which will boost the capture rate when
the user is interacting with the remote machine.  The idea is that they
can leave the target framerate at a lower value (say ~30FPS) but then we
can temporarily increase the frame rate when they are actively typing or
injecting other types of input.

(cherry picked from commit 269874e)

Bug: b:217468304, 1401760
Change-Id: Id10ba593390856a51222b96da4fc38c3604dfcd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4108265
Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1084465}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4115471
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5481@{#15}
Cr-Branched-From: 130f3e4-refs/heads/main@{#1084008}
trflynn89 pushed a commit that referenced this issue Apr 15, 2023
Roll ChromeOS Bigcore AFDO profile from 112-5563.14-1676891310-benchm…
b486000 
…ark-112.0.5599.0-r1 to 112-5563.14-1676891310-benchmark-112.0.5615.5-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-bigcore-chromium-beta
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: c-compiler-chrome@google.com
Change-Id: If5b405f7c5b19f3a404948100ba54a0bbe970315
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4292269
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5615@{#15}
Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}
trflynn89 pushed a commit that referenced this issue Oct 26, 2023
Add Metrics to Determine How Users Target the Non-Client Caption Area
992e878 
This change helps measure if users target the reserved grab handle
space or other parts of the non-client area (typically below the
caption buttons).

Bug: 1479060

(cherry picked from commit dc5c460)

Change-Id: Ica3ef2e77a8aec42531b54efc6e45a5d65e8ba7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4843950
Commit-Queue: Robert Liao <robliao@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Auto-Submit: Robert Liao <robliao@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1192714}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4850409
Cr-Commit-Position: refs/branch-heads/5993@{#15}
Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
trflynn89 pushed a commit that referenced this issue Dec 14, 2023
Incrementing VERSION to 120.0.6099.5
93fab43 
Change-Id: I277590bc13e109b64972b01c40f8d879e01898e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4995266
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6099@{#15}
Cr-Branched-From: e6ee450-refs/heads/main@{#1217362}
trflynn89 pushed a commit that referenced this issue Dec 19, 2023
Fix the broken tests when AppStorage is enabled(Part17).
c61d746 
When the kAppServiceStorage flag is enabled, AppService blocks the
app publishers creating until it's ready, after reading from the
AppStorage file. This affects some tests, e.g.
DeviceAPIServiceRegularUserTest.*, because no data path
for the profile:
Received signal 11 SEGV_MAPERR 000000000017
...
#9 0x7fb1f37f6ec7 base::FilePath::Append()
#10 0x7fb20a6396ec ash::BrowserContextHelper::GetBrowserContextPathByUserIdHash()
#11 0x55d607da3a0c ash::ProfileHelperImpl::GetUserByProfile()
#12 0x55d607da32f7 ash::ProfileHelper::IsPrimaryProfile()
#13 0x55d616260503 NearbySharingServiceFactory::IsNearbyShareSupportedForBrowserContext()
#14 0x55d6156cd0fc NotificationDisplayServiceImpl::NotificationDisplayServiceImpl()
#15 0x55d6156ccc49 std::__Cr::make_unique<>()
...
BrowserContextKeyedServiceFactory::GetServiceForBrowserContext()
#20 0x55d6156ccab2 NotificationDisplayServiceFactory::GetForProfile()
#21 0x55d605d350be apps::ExtensionAppsChromeOs::Initialize()
#22 0x55d605d8041b apps::PublisherHost::Initialize()
#23 0x55d605d8026c apps::PublisherHost::PublisherHost()

Actually TestingProfile can create FakeChromeUserManager[1]. So we
can get  FakeChromeUserManager directly.

Remove `scoped_user_manager_`, as that has been moved to TestProfile.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/5076443/20/chrome/test/base/testing_profile.cc

BUG=1385932, b:307623506

Change-Id: Ib26c7fc9fcfa950e01246df6e13a8f3ee449b22b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5134109
Reviewed-by: Ben Franz <bfranz@chromium.org>
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1239047}
trflynn89 pushed a commit that referenced this issue Jan 24, 2024
Roll ChromeOS Bigcore AFDO profile from 121-6126.0-1701082639-benchma…
d9e6eeb 
…rk-121.0.6154.0-r1 to 121-6126.0-1701688287-benchmark-121.0.6167.0-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-bigcore-chromium-beta
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: c-compiler-chrome@google.com
Change-Id: I9cfd69a7755173c670fe975264a7dff6ee6a4bb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5090747
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6167@{#15}
Cr-Branched-From: 222e786-refs/heads/main@{#1233107}
trflynn89 pushed a commit that referenced this issue Jul 9, 2024
Roll commits from side projects in M126
44dabcd 
Roll src/clank in M126 from 23089ba26953 to fcb6b842e3f0
Commits rolled:
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/23089ba26953..fcb6b842e3f0

Generated by: http://go/bbid/8747922926931452545

Change-Id: I76e456e2a2a1f95725fb945183bfd62eeb33ecc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5540668
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6478@{#15}
Cr-Branched-From: e6143ac-refs/heads/main@{#1300313}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branding This is a Rebel branding issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@trflynn89