fix: Slugifying non-ascii headers make duplicate permalinks (#264)

Joe-noh · RomanHotsiy · commit 6edbbe7b0c89 · 2017-05-03T11:01:53.000+03:00
diff --git a/lib/utils/md-renderer.ts b/lib/utils/md-renderer.ts
@@ -53,7 +53,8 @@ export class MdRenderer {
   }
 
   saveHeading(title: string, parent:MarkdownHeading = {id:null, children: this.headings}) :MarkdownHeading {
-    let slug = slugify(title);
+    // if title contains some non-ASCII characters (e.g. chinese) slugify returns empty string
+    let slug = slugify(title) || title;
     let id = slug;
     if (parent && parent.id) id = `${parent.id}/${id}`;
     parent.children = parent.children || {};

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,8 @@ export class MdRenderer {`
`53`	`53`	`}`
`54`	`54`
`55`	`55`	`saveHeading(title: string, parent:MarkdownHeading = {id:null, children: this.headings}) :MarkdownHeading {`
`56`		`- let slug = slugify(title);`
	`56`	`+ // if title contains some non-ASCII characters (e.g. chinese) slugify returns empty string`
	`57`	`+ let slug = slugify(title) \|\| title;`
`57`	`58`	`let id = slug;`
`58`	`59`	if (parent && parent.id) id = `${parent.id}/${id}`;
`59`	`60`	`parent.children = parent.children \|\| {};`