Reduce schema reuse and promote dependencies to top level directory [Part 5] #1511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
July 19, 2023 18:00
…cesive-schema-reuse-5
…cesive-schema-reuse-5
…modes and discriminator
…cesive-schema-reuse-5
2 tasks
added 2 commits
July 25, 2023 13:05
…cesive-schema-reuse-5
noon-dawg
reviewed
Jul 25, 2023
noon-dawg
reviewed
Jul 25, 2023
openapi/components/schemas/Rules/Actions/offer-purchase-bump.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Chris <85164331+noon-dawg@users.noreply.github.com>
noon-dawg
previously approved these changes
Jul 25, 2023
…cesive-schema-reuse-5
…definitions into fix-excesive-schema-reuse-5
|
@Rebilly/js @Rebilly/php @Rebilly/docs please review |
noon-dawg
reviewed
Jul 28, 2023
Co-authored-by: Chris <85164331+noon-dawg@users.noreply.github.com>
noon-dawg
approved these changes
Jul 28, 2023
ashkarpetin
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The goal is to reduce excessive schema reuse in the scope of cleaning up the api-definitions files.
Cleaned subschemas (not referenced from the paths ) are moved to top level directory.
Links
Part 4
Checklist