Add deprecated currencies (GWY-14291) #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavcodev
reviewed
Dec 5, 2019
slavcodev
reviewed
Dec 5, 2019
slavcodev
reviewed
Dec 5, 2019
slavcodev
reviewed
Dec 5, 2019
ashkarpetin
reviewed
Dec 5, 2019
ashkarpetin
reviewed
Dec 5, 2019
ashkarpetin
reviewed
Dec 5, 2019
slavcodev
reviewed
Dec 5, 2019
slavcodev
reviewed
Dec 5, 2019
src/Currency.php
Outdated
| { | ||
| return array_filter( | ||
| self::$currencies, | ||
| function ($currencyCode) { |
There was a problem hiding this comment.
Suggested change
| function ($currencyCode) { | |
| static function (array $currency): bool { |
There was a problem hiding this comment.
i think it doesn't make much difference in this case, since i'm not using self::$currencies anymore
slavcodev
reviewed
Dec 5, 2019
slavcodev
reviewed
Dec 5, 2019
slavcodev
reviewed
Dec 5, 2019
Co-Authored-By: Veaceslav Medvedev <slavcopost@gmail.com>
ashkarpetin
approved these changes
Dec 5, 2019
slavcodev
approved these changes
Dec 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Returning deprecated currencies back to the library.
deprecatedpropertygetCurrencies()method to return only active currenciesgetCurrenciesIncludingDeprecated()method to get all the currenciesLinks
https://jira.ilabsinc.com/browse/GWY-14291