form submission with error handling, PR includes suggestionBox #339
+253
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeHarlan
requested review from
domitriusclark,
magnificode,
mbifulco and
racedale
as code owners
|
Deploy request for rebuild-black-business accepted. Accepted with commit 4662bbc https://app.netlify.com/sites/rebuild-black-business/deploys/5f5681e16195e00008999141 |
|
|
@juanri0s Chakra components were giving us a hard time with the Netlify so this is an with inline styling. I can make a CSS module to get the focus and hover state more inline with the Chakra defaults, but was thinking about avoiding a random CSS file when there aren't any anywhere else. totally down to do that though. On blank submission there should be a message popping up at the top, maybe we can bold that or something to make it more apparent? |
|
@SeHarlan This PR will be on hold until we figure out an issue with the new business pages feature since its causing long build times |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR
Related to #
Fixes #283
Pages/Interfaces that will change
related to SuggestionBox:
ContactCard.js
about.js
related to Form submissions with error handling:
AritableServices.js
BusinessSignUpForm.js
AllySignUpForm.js
Screenshots / video of changes
Drop some screenshots of the before and after of your work here. Better yet, take a screen recording using a tool like Loom
Steps to test
I've changed the elements in the suggestion box to be wrapped in a generic form (with the proper Netlify attributes) and with a default <input type="submit> so it should behave like a normal form now. Before it was using only Chakra components like PrimaryButton and FormControl and the "form" was not behaving as expected when it came to submitting with Netlify integration.
Additional notes
I did some minor clean up and basic error handling for the other forms and Airtable service functions, right now it displays the error message to the user via the validationMessage state. Let me know if that's alright or should be changed back!