Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Justice Counts] Replace curly with straight apostrophe in agency name #1331

Merged
merged 2 commits into from
May 14, 2024

Conversation

morden35
Copy link
Contributor

@morden35 morden35 commented May 13, 2024

Description of the change

Replace curly apostrophes () with straight apostrophes (') in agency names upon creation/editing in the admin panel.

How I Tested

I created a new agency that contained curly apostrophes within the agency name. The agency was properly saved in the database with straight apostrophes. I also attempted to edit the agency name and add in a curly apostrophe. I confirmed that this was saved with the expected straight apostrophe.

Screenshot 2024-05-13 at 4 07 14 PM Screenshot 2024-05-13 at 4 07 49 PM

Type of change

All pull requests must have at least one of the following labels applied (otherwise the PR will fail):

Label Description
Type: Bug non-breaking change that fixes an issue
Type: Feature non-breaking change that adds functionality
Type: Breaking Change fix or feature that would cause existing functionality to not work as expected
Type: Non-breaking refactor change addresses some tech debt item or prepares for a later change, but does not change functionality
Type: Configuration Change adjusts configuration to achieve some end related to functionality, development, performance, or security
Type: Dependency Upgrade upgrades a project dependency - these changes are not included in release notes

Related issues

Related to #28872

Checklists

Development

This box MUST be checked by the submitter prior to merging:

  • Double- and triple-checked that there is no Personally Identifiable Information (PII) being mistakenly added in this pull request

These boxes should be checked by the submitter prior to merging:

  • Tests have been written to cover the code changed/added as part of this pull request

Code review

These boxes should be checked by reviewers prior to merging:

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has been moved out of a Draft state, has no "Work In Progress" label, and has assigned reviewers
  • Potential security implications or infrastructural changes have been considered, if relevant

@morden35 morden35 requested review from a team, mxosman and nichelle-hall May 13, 2024 21:14
@morden35
Copy link
Contributor Author

morden35 commented May 13, 2024

Based on the following sql query, we should update the following agency names (backfill fix):
select id, name from source where name like '%’%';
results in

97|Franklin County Public Defender’s Office
99|Story County Attorney’s Office
100|Franklin County Prosecutor’s Office
123|Columbus City Attorney’s Office
663|Aileen O’Connor Residential House
1571|Clackamas County Sheriff’s Office Parole and Probation Division
1590|Marion County Sheriff’s Office
1595|Tillamook County Sheriff’s Office Community Corrections Division
1526|Hamilton County Sheriff’s Office
1530|Thurston County Prosecuting Attorney’s Office
1531|Thurston County Sheriff’s Office
127|Cass County Sheriff’s Department

Copy link
Contributor

@mxosman mxosman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much, Michelle!

@morden35 morden35 merged commit cc30319 into main May 14, 2024
7 checks passed
Copy link
Collaborator

@lilidworkin lilidworkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you Michelle! You have the green light from me to update those names and then just give CSG (esp Matt) a heads up after so we knows we knocked this out :)

@morden35
Copy link
Contributor Author

Awesome, thank you Michelle! You have the green light from me to update those names and then just give CSG (esp Matt) a heads up after so we knows we knocked this out :)

Sounds good and will do! I will wait for this pr to make it into the prod deploy before doing the backwards change

@morden35
Copy link
Contributor Author

Backwards changes are complete and CSG has been notified. The sql query above now result in 0 rows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants