Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint-staged configuration #240

Merged
merged 1 commit into from
Oct 28, 2020
Merged

Fix lint-staged configuration #240

merged 1 commit into from
Oct 28, 2020

Conversation

macfarlandian
Copy link
Collaborator

@macfarlandian macfarlandian commented Oct 28, 2020

Description of the change

husky and lint-staged are a bit finicky about how they are used inside of a monorepo since they interact with both your npm package and your git repo, and after a few lint errors slipped through to CI I realized that the linters weren't actually running properly inside the husky pre-commit hook. Pushing the lint-staged configuration down to the individual packages, as recommended here (and referenced from the official lint-staged docs), should fix this. It makes for a bit more redundant configuration but it doesn't really seem like there's a better alternative!

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Configuration change (adjusts configuration to achieve some end related to functionality, development, performance, or security)

Related issues

Closes #239

Checklists

Development

These boxes should be checked by the submitter prior to merging:

  • Manual testing against realistic data has been performed locally

Code review

These boxes should be checked by reviewers prior to merging:

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has been moved out of a Draft state, has no "Work In Progress" label, and has assigned reviewers
  • Potential security implications or infrastructural changes have been considered, if relevant

@coveralls
Copy link

coveralls commented Oct 28, 2020

Pull Request Test Coverage Report for Build 334365679

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 5.164%

Totals Coverage Status
Change from base Build 320690911: 0.0%
Covered Lines: 60
Relevant Lines: 1390

💛 - Coveralls

Copy link
Member

@jessex jessex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know a better alternative either 👍

Copy link

@jovergaag jovergaag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what we're doing in pulse-dashboard as well.

@macfarlandian macfarlandian merged commit 4a25981 into master Oct 28, 2020
@macfarlandian macfarlandian deleted the ian/239-fix-hook branch October 28, 2020 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure lint tests are run in pre-commit hooks
4 participants