Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move recidivism section to the Prison page #245

Merged
merged 2 commits into from
Oct 30, 2020
Merged

Conversation

macfarlandian
Copy link
Collaborator

@macfarlandian macfarlandian commented Oct 30, 2020

Description of the change

This new metric is apparently supposed to be included in the Prison page, but I had put it on the Sentencing page by mistake. This just moves the code over, no functionality change other than that.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Configuration change (adjusts configuration to achieve some end related to functionality, development, performance, or security)

Related issues

Closes #244

Checklists

Development

These boxes should be checked by the submitter prior to merging:

  • Manual testing against realistic data has been performed locally

Code review

These boxes should be checked by reviewers prior to merging:

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has been moved out of a Draft state, has no "Work In Progress" label, and has assigned reviewers
  • Potential security implications or infrastructural changes have been considered, if relevant

@coveralls
Copy link

coveralls commented Oct 30, 2020

Pull Request Test Coverage Report for Build 338422937

  • 0 of 11 (0.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 25.408%

Changes Missing Coverage Covered Lines Changed/Added Lines %
public-dashboard-client/src/page-prison/PagePrison.js 0 11 0.0%
Files with Coverage Reduction New Missed Lines %
public-dashboard-client/src/page-prison/PagePrison.js 1 0%
public-dashboard-client/src/page-sentencing/PageSentencing.js 1 0%
Totals Coverage Status
Change from base Build 338368819: 0.0%
Covered Lines: 393
Relevant Lines: 1492

💛 - Coveralls

Copy link
Member

@jessex jessex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @macfarlandian

@macfarlandian macfarlandian merged commit 07a66d5 into master Oct 30, 2020
@macfarlandian macfarlandian deleted the ian/244-wrong-page branch October 30, 2020 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move recidivism charts to Prison page
3 participants