Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tenant homepage #344

Merged
merged 12 commits into from
Mar 2, 2021
Merged

Tenant homepage #344

merged 12 commits into from
Mar 2, 2021

Conversation

macfarlandian
Copy link
Collaborator

Description of the change

The homepage for a tenant, with links to all available narratives.

Screen Shot 2021-02-25 at 5 09 38 PM

Highlights:

  • The links on this page are mostly the same as what's on the bottom of the narrative pages, so that code is shared. It's also now a uniform grid
  • Designs used to call for these links to be on a separate "collections" homepage; that is no longer a thing, so that page has been removed from navigation and routing.
  • It was not evident on the narrative pages due to their internal navigation feature, but for reasons I do not fully understand, the router does not return to the top of the page by default after you click through a navigation link. We generally do want that, but our routes are a bit of a special case because some of them correspond to intra-page anchors rather than different pages. This is pretty easy to deal with at the moment with a scroll management component, since all of the routes are parameterized in our Mobx stores

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Configuration change (adjusts configuration to achieve some end related to functionality, development, performance, or security)

Related issues

Closes #286

Checklists

Development

These boxes should be checked by the submitter prior to merging:

  • Manual testing against realistic data has been performed locally

Code review

These boxes should be checked by reviewers prior to merging:

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has been moved out of a Draft state, has no "Work In Progress" label, and has assigned reviewers
  • Potential security implications or infrastructural changes have been considered, if relevant

@coveralls
Copy link

coveralls commented Feb 26, 2021

Pull Request Test Coverage Report for Build 615405207

  • 39 of 43 (90.7%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 70.865%

Changes Missing Coverage Covered Lines Changed/Added Lines %
spotlight-client/src/OtherNarrativeLinks/OtherNarrativeLinks.tsx 14 18 77.78%
Totals Coverage Status
Change from base Build 615380693: 0.09%
Covered Lines: 2360
Relevant Lines: 3221

💛 - Coveralls

Base automatically changed from ian/309-mobile-dropdowns to master March 2, 2021 20:40
@macfarlandian macfarlandian merged commit 06fe86a into master Mar 2, 2021
@macfarlandian macfarlandian deleted the ian/286-tenant-home branch March 2, 2021 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tenant home page
3 participants