Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregate and display unknown values #370

Merged
merged 2 commits into from
Mar 25, 2021
Merged

Conversation

macfarlandian
Copy link
Collaborator

@macfarlandian macfarlandian commented Mar 24, 2021

Description of the change

When demographic categories are reported as unknown (which can happen due to data quality or other issues), counts the number of occurrences and displays them in a footnote.

Screen Shot 2021-03-23 at 4 47 47 PM

(The snapshot change occurred because one of the fixtures randomly had a few unknowns in it. I took them out to more consistently isolate the cases where unknowns are present or absent.)

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Configuration change (adjusts configuration to achieve some end related to functionality, development, performance, or security)

Related issues

Closes #330

Checklists

Development

These boxes should be checked by the submitter prior to merging:

  • Manual testing against realistic data has been performed locally

Code review

These boxes should be checked by reviewers prior to merging:

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has been moved out of a Draft state, has no "Work In Progress" label, and has assigned reviewers
  • Potential security implications or infrastructural changes have been considered, if relevant

@coveralls
Copy link

coveralls commented Mar 25, 2021

Pull Request Test Coverage Report for Build 681350396

  • 70 of 70 (100.0%) changed or added relevant lines in 14 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 73.36%

Totals Coverage Status
Change from base Build 680511106: 0.5%
Covered Lines: 2759
Relevant Lines: 3639

💛 - Coveralls

@macfarlandian macfarlandian merged commit 3c41224 into master Mar 25, 2021
@macfarlandian macfarlandian deleted the ian/330-unknowns branch March 25, 2021 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle "unknowns" consistently
3 participants