Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-launch polish, part 1 #371

Merged
merged 9 commits into from
Mar 26, 2021
Merged

Pre-launch polish, part 1 #371

merged 9 commits into from
Mar 26, 2021

Conversation

macfarlandian
Copy link
Collaborator

@macfarlandian macfarlandian commented Mar 25, 2021

Description of the change

Assorted minor visual and navigational fixes; see linked issue for a full accounting (or the individual commits on this branch).

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Configuration change (adjusts configuration to achieve some end related to functionality, development, performance, or security)

Related issues

Part of #366

Checklists

Development

These boxes should be checked by the submitter prior to merging:

  • Manual testing against realistic data has been performed locally

Code review

These boxes should be checked by reviewers prior to merging:

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has been moved out of a Draft state, has no "Work In Progress" label, and has assigned reviewers
  • Potential security implications or infrastructural changes have been considered, if relevant

Base automatically changed from ian/330-unknowns to master March 25, 2021 22:02
@coveralls
Copy link

coveralls commented Mar 26, 2021

Pull Request Test Coverage Report for Build 688436427

  • 87 of 87 (100.0%) changed or added relevant lines in 18 files are covered.
  • 17 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-0.09%) to 73.267%

Files with Coverage Reduction New Missed Lines %
spotlight-client/src/AuthWall/AuthWall.tsx 1 79.17%
spotlight-client/src/DataStore/UiStore.ts 1 95.24%
spotlight-client/src/metricsApi/types.ts 1 33.33%
spotlight-client/src/SiteNavigation/SiteNavigationMobile.tsx 1 96.88%
spotlight-client/src/VerificationRequired/VerificationRequired.tsx 1 50.0%
spotlight-client/src/VizRecidivismRateCumulative/VizRecidivismRateCumulative.tsx 1 88.24%
spotlight-client/src/VizHistoricalPopulationBreakdown/VizHistoricalPopulationBreakdown.tsx 2 68.42%
spotlight-client/src/contentModels/RecidivismRateMetric.ts 3 91.26%
spotlight-client/src/contentModels/SupervisionSuccessRateMetric.ts 6 87.06%
Totals Coverage Status
Change from base Build 688051047: -0.09%
Covered Lines: 2761
Relevant Lines: 3645

💛 - Coveralls

@macfarlandian
Copy link
Collaborator Author

the flaky tests on this package are getting out of hand so I am skipping the problem ones (it's only a handful out of 300+) so they stop blocking these PRs before launch. #353 already exists to fix this more permanently, which I think should wait until next week after the v2 release is put to bed

@macfarlandian macfarlandian merged commit ecfd4a5 into master Mar 26, 2021
@macfarlandian macfarlandian deleted the ian/366-polish branch March 26, 2021 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants