Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assorted iOS polish and bugfixes #396

Merged
merged 8 commits into from
Apr 19, 2021
Merged

assorted iOS polish and bugfixes #396

merged 8 commits into from
Apr 19, 2021

Conversation

macfarlandian
Copy link
Collaborator

@macfarlandian macfarlandian commented Apr 19, 2021

Description of the change

Resolves most of the small issues observed in iOS from the linked ticket (except for one that still has me stumped, the only iOS one not checked off as of this writing). You can review one commit at a time if you'd prefer to isolate each bug, they mostly correspond 1:1 (excepting a revision to the unique ID feature for the sentence types chart).

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Configuration change (adjusts configuration to achieve some end related to functionality, development, performance, or security)

Related issues

part of #373

Checklists

Development

These boxes should be checked by the submitter prior to merging:

  • Manual testing against realistic data has been performed locally

Code review

These boxes should be checked by reviewers prior to merging:

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has been moved out of a Draft state, has no "Work In Progress" label, and has assigned reviewers
  • Potential security implications or infrastructural changes have been considered, if relevant

@coveralls
Copy link

coveralls commented Apr 19, 2021

Pull Request Test Coverage Report for Build 764442303

  • 16 of 17 (94.12%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 73.388%

Changes Missing Coverage Covered Lines Changed/Added Lines %
spotlight-client/src/SiteNavigation/SiteNavigationMobile.tsx 6 7 85.71%
Totals Coverage Status
Change from base Build 756277862: 0.07%
Covered Lines: 2782
Relevant Lines: 3670

💛 - Coveralls

Copy link

@jovergaag jovergaag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I did notice a console warming the first time a filter is selected on any page. We saw this in Lantern for a while and it was in fact a memory leak, something to consider looking into.

Screen Shot 2021-04-19 at 1 31 08 PM

@macfarlandian
Copy link
Collaborator Author

@jovergaag yeah I'm pretty sure it's an issue with react-spring ... supposedly addressed in the next major version. I created #401 to capture that because I'm pretty sure it's just been living in my head! Thanks for the call out

@macfarlandian macfarlandian merged commit 6493607 into main Apr 19, 2021
@macfarlandian macfarlandian deleted the ian/373-polish branch April 19, 2021 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants