Share modal

[macfarlandian]

Description of the change

Includes a modal in the main navigation with buttons for copying the page URL or sharing it directly to email, facebook, or twitter. Including the section number is optional.

(it will reflect whatever the current host is, which is why it's just showing my local dev URL)

It's possible we might add more copy to the modal or the links besides just the URL, but no one has given me anything yet so I didn't want to continue waiting for it. Wouldn't change the basic functionality anyway so easy enough to add later if needed.

Type of change

• Bug fix (non-breaking change that fixes an issue)
• New feature (non-breaking change that adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Configuration change (adjusts configuration to achieve some end related to functionality, development, performance, or security)

Related issues

Closes #348

Checklists

Development

These boxes should be checked by the submitter prior to merging:

• Manual testing against realistic data has been performed locally

Code review

These boxes should be checked by reviewers prior to merging:

• This pull request has a descriptive title and information useful to a reviewer
• This pull request has been moved out of a Draft state, has no "Work In Progress" label, and has assigned reviewers
• Potential security implications or infrastructural changes have been considered, if relevant

[coveralls]

Pull Request Test Coverage Report for Build 818733565

• 38 of 41 (92.68%) changed or added relevant lines in 7 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.3%) to 73.664%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
spotlight-client/src/SiteNavigation/SiteNavigationContainer.tsx	3	4	75.0%
spotlight-client/src/ShareModal/ShareModal.tsx	23	25	92.0%

Totals
Change from base Build 814504662:	0.3%
Covered Lines:	2870
Relevant Lines:	3769

---

💛 - Coveralls

[jovergaag]

Couple of comments but nothing show stopping!

[jovergaag]

Is there a setting to have this open in a new tab? After sending the email it closes the tab so I lose the dashboard completely.

[macfarlandian]

unfortunately there is not, but I guess it would be pretty trivial to just write my own mailto link here instead ... I was just using this because it was already there but that's a good point!

[macfarlandian]

after digging around some more I found that there actually is a way to do this via the library, and it actually seems to work more consistently than a plain mailto link with target="_blank" despite being slightly kludgy, so that's what I went with!

[jovergaag]

Are these things we would want to include in the component library?

[macfarlandian]

yeah, probably? I should do a pass to move all of the icons in this application over to that package (if they're not there already) but I didn't want to block on that here.