Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing ) #51

Merged
merged 1 commit into from
May 26, 2017
Merged

Fix missing ) #51

merged 1 commit into from
May 26, 2017

Conversation

pysysops
Copy link
Contributor

This fixes issue #50 which causes the script to exit with unexpected EOF while looking for matching )'

@stephenwb
Copy link
Contributor

mea culpa. Thanks for fixing @pysysops

@pysysops
Copy link
Contributor Author

pysysops commented May 25, 2017

haha... no problem @stephenwb now if only I can get rid of the oscap problems on CentOS 7:

    aws: --- Starting Remediation ---
    aws: Downloading: https://www.redhat.com/security/data/oval/Red_Hat_Enterprise_Linux_7.xml ... ok
    aws:        Disable Prelinking
    aws:        xccdf_org.ssgproject.content_rule_disable_prelink
    aws: Ident
    aws:
    aws:        error
    aws:
    aws:        Ensure System Log Files Have Correct Permissions
    aws:        xccdf_org.ssgproject.content_rule_rsyslog_files_permissions
    aws: Ident
    aws:
    aws:        fixed
    aws:
    aws:        Ensure auditd Collects Information on the Use of Privileged Commands
    aws:        xccdf_org.ssgproject.content_rule_audit_rules_privileged_commands
    aws: Ident
    aws:
    aws:        error
    aws:

Nothing to do with this project btw...

@pysysops
Copy link
Contributor Author

This also fixes #52

@pysysops
Copy link
Contributor Author

I was experiencing an issue with oscap scans when using the auditd rules generated by ssg-supplemental.sh. This fixes that issue.

Before:
image

After:
image

Open to any feedback.

Thanks,

Tim Birkett.

@pysysops pysysops changed the title Fix missing ) Fix missing ) and oscap audit rules May 25, 2017
Copy link
Contributor

@stephenwb stephenwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pysysops: See the discussion with @shawndwells in pull request #46 about moving those restrictions on the auid in the rules to lines 307 and 309. Putting them back in to line 336 makes no sense. Are you required to pass the oscap audit rules with no chance for explanation? Better to explain to your approving authority why the test doesn't pass, or find and submit changes to the oscap audit validation script(s) so that it does, than revert a change that makes the audit rules more efficient.

@pysysops
Copy link
Contributor Author

Apologies, I had missed that!

@pysysops pysysops changed the title Fix missing ) and oscap audit rules Fix missing ) May 26, 2017
@pysysops
Copy link
Contributor Author

I've reset back to the original commit. Thanks for the link to the previous discussion, really interesting.

@fcaviggia fcaviggia merged commit 4c751c2 into RedHatGov:master May 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants