Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHCLOUD-20571] Label the DBs #679

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Conversation

gburges
Copy link
Contributor

@gburges gburges commented Jul 28, 2022

No description provided.

@gburges gburges force-pushed the lblr branch 5 times, most recently from baf5336 to 834f303 Compare July 28, 2022 16:13
@psav psav marked this pull request as draft July 29, 2022 12:12
@psav psav changed the title [WIP] Label the DBs (RHCLOUD-20571) [RHCLOUD-20571] Label the DBs Jul 29, 2022
@gburges gburges force-pushed the lblr branch 2 times, most recently from d2895b7 to 44ed6d4 Compare August 2, 2022 12:33
@gburges gburges force-pushed the lblr branch 5 times, most recently from c17cf07 to 3220751 Compare March 14, 2023 14:35
@gburges
Copy link
Contributor Author

gburges commented Mar 15, 2023

@psav tested locally, now the new labels are applied correctly

@gburges gburges marked this pull request as ready for review March 16, 2023 11:34
@gburges gburges requested a review from psav April 19, 2023 12:55
@psav
Copy link
Collaborator

psav commented Apr 19, 2023

Needs some tests for assertion

Copy link
Collaborator

@psav psav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs some assertion tests

@gburges gburges force-pushed the lblr branch 3 times, most recently from 6fef1e8 to 941aefb Compare April 27, 2023 16:56
@gburges
Copy link
Contributor Author

gburges commented May 15, 2023

/retest

@adamrdrew
Copy link
Contributor

/retest

1 similar comment
@gburges
Copy link
Contributor Author

gburges commented Jul 27, 2023

/retest

@gburges
Copy link
Contributor Author

gburges commented Sep 5, 2023

/retest

@gburges
Copy link
Contributor Author

gburges commented Sep 11, 2023

/retest

@gburges gburges requested a review from psav September 12, 2023 08:49
psav
psav previously requested changes Sep 12, 2023
Copy link
Collaborator

@psav psav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change

tests/kuttl/test-cyndi-local-db/01-pods.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@adamrdrew adamrdrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're close! Just address the stuff I suggested and we should be good.

Copy link
Contributor

@adamrdrew adamrdrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamrdrew adamrdrew merged commit 93e26ee into RedHatInsights:master Oct 20, 2023
2 checks passed
psav added a commit that referenced this pull request Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants