-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHCLOUD-20571] Label the DBs #679
Conversation
baf5336
to
834f303
Compare
controllers/cloud.redhat.com/providers/featureflags/localfeatureflags.go
Show resolved
Hide resolved
d2895b7
to
44ed6d4
Compare
c17cf07
to
3220751
Compare
@psav tested locally, now the new labels are applied correctly |
Needs some tests for assertion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs some assertion tests
6fef1e8
to
941aefb
Compare
/retest |
7e06c81
to
4947449
Compare
/retest |
1 similar comment
/retest |
/retest |
8fa6d8e
to
152f78e
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're close! Just address the stuff I suggested and we should be good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.