Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics): RHINENG-9891 collect info about path+source in APIv2 #2072

Merged
merged 1 commit into from
May 30, 2024

Conversation

skateman
Copy link
Member

@skateman skateman commented May 8, 2024

The idea is to store two additional tags in yabeda metrics:

  • Obfuscated path in the /entity/:id/entity/:id/entity/:id form
  • Where the request is coming from (frontend, client or cannot determine)

With these available we can do more fine-grained metrics on APIv2 endpoints. For the source we will rely on platform/chrome passing a special header to every frontend request.

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@skateman skateman added the APIv2 REST API v2 label May 8, 2024
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.80%. Comparing base (0434e6d) to head (876202f).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2072   +/-   ##
=======================================
  Coverage   98.80%   98.80%           
=======================================
  Files         228      228           
  Lines        4850     4861   +11     
=======================================
+ Hits         4792     4803   +11     
  Misses         58       58           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skateman skateman force-pushed the v2-metrics branch 2 times, most recently from b94a0a9 to 3dffaf5 Compare May 29, 2024 14:29
@skateman skateman marked this pull request as ready for review May 29, 2024 14:31
@skateman skateman requested a review from a team as a code owner May 29, 2024 14:31
Copy link
Member

@romanblanco romanblanco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@skateman skateman enabled auto-merge (rebase) May 30, 2024 13:03
@skateman skateman merged commit 13f6275 into RedHatInsights:master May 30, 2024
10 checks passed
@skateman skateman deleted the v2-metrics branch May 30, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APIv2 REST API v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants