Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates css class from .pf-c-data-toolbar__item to .pf-c-toolbar__item #568

Merged

Conversation

josejulio
Copy link
Member

primary-toolbar.scss

DataToolbar was renamed to Toolbar, and the related css classes too

Note that the data-toolbar is used also in: but i didn't touch anything because I think that someone is working there.

.pf-c-data-toolbar__content {
.pf-c-data-toolbar__item:last-child { @include rem('min-width', 200px); }

Before:

  • Desktop
    Screenshot_2020-06-11_15-10-59
  • Mobile
    Screenshot_2020-06-11_15-13-43

After:

  • Desktop
    Screenshot_2020-06-11_16-16-47

  • Mobile

Screenshot_2020-06-11_16-17-04

 primary-toolbar.scss

 DataToolbar was renamed to Toolbar, and the related css classes too
@josejulio josejulio mentioned this pull request Jun 11, 2020
14 tasks
@Hyperkid123 Hyperkid123 merged commit 9c4567e into RedHatInsights:PF4-update Jun 12, 2020
@Hyperkid123
Copy link
Contributor

the fix is published in @redhat-cloud-services/frontend-components@2.1.0-beta.1 version

@josejulio josejulio deleted the update-css-data-toolbar branch June 15, 2020 14:44
@josejulio
Copy link
Member Author

the fix is published in @redhat-cloud-services/frontend-components@2.1.0-beta.1 version

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants