Skip to content
This repository has been archived by the owner on Dec 8, 2020. It is now read-only.

decide whether to use labels or names when looking for CVs #23

Closed
evgeni opened this issue Jan 24, 2017 · 5 comments
Closed

decide whether to use labels or names when looking for CVs #23

evgeni opened this issue Jan 24, 2017 · 5 comments

Comments

@evgeni
Copy link
Member

evgeni commented Jan 24, 2017

we currently use names, those might change. labels are better. also add docs saying so.

identified in #18
@Rocco83
Copy link
Contributor

Rocco83 commented Feb 2, 2017

As the title is "decide whether", +1 on labels.
Documentation has to say that also that labels should be the same as names and space should not be used in names, btw :)

@evgeni evgeni mentioned this issue Mar 12, 2017
Closed
@bergsjoh
Copy link

Why not check both, if name fails check label.

@evgeni
Copy link
Member Author

evgeni commented Mar 15, 2017

IIRC names don't have to be unique. So I'd rather not do them in the long term.

This was referenced Apr 13, 2017
Open
Open
@alosadagrande
Copy link

Names on CV are unique otherwise an error is thrown while saving

@peppos peppos mentioned this issue Apr 26, 2018
Merged
@evgeni
Copy link
Member Author

evgeni commented May 3, 2018

fixed in b997a78

@evgeni evgeni closed this as completed May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@evgeni @Rocco83 @bergsjoh @alosadagrande