Fix ERROR: You potentially provided an mal-formed URL! #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi when we have a URL like this http://vimeo.com/api/oembed.json?url=/web/20131219172814/http://vimeo.com/80375746&api=1&player_id=preroll&height=354&width=630&callback will cause an Error that is You potentially provided a malformed URL! So as you can see the URL is not mal-formed, so I add 3 lines to fix that issue which checks if the character after the ":" is a digit
1 task
Closed
Relkci
added a commit
to Relkci/EyeWitness
that referenced
this pull request
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, when you have a URL like this
http://vimeo.com/api/oembed.json?url=/web/20131219172814/http://vimeo.com/80375746&api=1&player_id=preroll&height=354&width=630&callback
this will cause an ERROR
which is ERROR: You potentially provided an mal-formed URL!
So as you can see the URL is not mal-formed
the code check if there are two Colon, and try to extract the port after the second colon in the URL, but the after the second colon there are string not digit so that will cause the ERROR
So I add some lines to check if the value after the second colon is a digit or not