Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 1414 remove hard limit on ft.search #1416

Merged
merged 4 commits into from
Aug 16, 2020
Merged

Conversation

ashtul
Copy link
Contributor

@ashtul ashtul commented Aug 13, 2020

fix #1414

@codecov
Copy link

codecov bot commented Aug 13, 2020

Codecov Report

Merging #1416 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1416      +/-   ##
==========================================
- Coverage   80.85%   80.83%   -0.02%     
==========================================
  Files         143      143              
  Lines       20084    20100      +16     
==========================================
+ Hits        16238    16247       +9     
- Misses       3846     3853       +7     
Impacted Files Coverage Δ
src/config.h 100.00% <ø> (ø)
src/search_options.h 100.00% <ø> (ø)
src/aggregate/aggregate_request.c 96.99% <100.00%> (ø)
src/config.c 85.45% <100.00%> (+0.89%) ⬆️
src/legacy_gc.c 85.10% <0.00%> (-3.83%) ⬇️
src/gc.c 89.07% <0.00%> (ø)
src/rules.c 89.09% <0.00%> (+0.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c444fc...f46726c. Read the comment docs.

Copy link
Collaborator

@MeirShpilraien MeirShpilraien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small comment, other then this it looks good.

src/pytest/test_config.py Outdated Show resolved Hide resolved
@ashtul ashtul merged commit dcbbefc into master Aug 16, 2020
@ashtul ashtul deleted the config-max-results branch August 16, 2020 07:00
ashtul added a commit that referenced this pull request Aug 16, 2020
* Fix issue 1414 remove hard limit on ft.search

* add docs

* print out unlimited

(cherry picked from commit dcbbefc)
ashtul added a commit that referenced this pull request Aug 16, 2020
* Fix issue 1414 remove hard limit on ft.search (#1416)

* Fix issue 1414 remove hard limit on ft.search

* add docs

* print out unlimited

(cherry picked from commit dcbbefc)

* remove test from other commit

* Update Clients.md (#1373)

Add redisearch-api-rs 

(cherry picked from commit 5e0b66b)

* fix -20* query (#1374)

(cherry picked from commit 8a28d5c)

* check NewAddDocumentCtx return value in rs_api (#1291)

* check NewAddDocumentCtx ret val in rs_api

(cherry picked from commit 3f89408)

Co-authored-by: Jake Angerman <kerneljake@users.noreply.github.com>
ashtul added a commit that referenced this pull request Aug 31, 2020
* Fix issue 1414 remove hard limit on ft.search

* add docs

* print out unlimited

(cherry picked from commit dcbbefc)
(cherry picked from commit 81a282d)
ashtul added a commit that referenced this pull request Aug 31, 2020
* Fix issue 1414 remove hard limit on ft.search

* add docs

* print out unlimited

(cherry picked from commit dcbbefc)
ashtul added a commit that referenced this pull request Aug 31, 2020
* Fix issue 1414 remove hard limit on ft.search (#1416)

* Fix issue 1414 remove hard limit on ft.search

* add docs

* print out unlimited

(cherry picked from commit dcbbefc)
(cherry picked from commit 81a282d)

* check NewAddDocumentCtx return value in rs_api (#1291)

* check NewAddDocumentCtx ret val in rs_api

(cherry picked from commit 3f89408)
(cherry picked from commit 481ac38)

* remove test from other pr not picked

* skip on cluster

* Update Clients.md (#1373)

Add redisearch-api-rs

(cherry picked from commit 5e0b66b)

* fix -20* query (#1374)

(cherry picked from commit 8a28d5c)

* Fix issue 1414 remove hard limit on ft.search (#1416)

* Fix issue 1414 remove hard limit on ft.search

* add docs

* print out unlimited

(cherry picked from commit dcbbefc)

* silence compiler (#1375) (#1418)

(cherry picked from commit 2e171ae)

Co-authored-by: Jake Angerman <kerneljake@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configurable maximum results (PM-737)
2 participants