-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue 1414 remove hard limit on ft.search #1416
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1416 +/- ##
==========================================
- Coverage 80.85% 80.83% -0.02%
==========================================
Files 143 143
Lines 20084 20100 +16
==========================================
+ Hits 16238 16247 +9
- Misses 3846 3853 +7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A small comment, other then this it looks good.
* Fix issue 1414 remove hard limit on ft.search * add docs * print out unlimited (cherry picked from commit dcbbefc)
* Fix issue 1414 remove hard limit on ft.search (#1416) * Fix issue 1414 remove hard limit on ft.search * add docs * print out unlimited (cherry picked from commit dcbbefc) * remove test from other commit * Update Clients.md (#1373) Add redisearch-api-rs (cherry picked from commit 5e0b66b) * fix -20* query (#1374) (cherry picked from commit 8a28d5c) * check NewAddDocumentCtx return value in rs_api (#1291) * check NewAddDocumentCtx ret val in rs_api (cherry picked from commit 3f89408) Co-authored-by: Jake Angerman <kerneljake@users.noreply.github.com>
* Fix issue 1414 remove hard limit on ft.search * add docs * print out unlimited (cherry picked from commit dcbbefc)
* Fix issue 1414 remove hard limit on ft.search (#1416) * Fix issue 1414 remove hard limit on ft.search * add docs * print out unlimited (cherry picked from commit dcbbefc) (cherry picked from commit 81a282d) * check NewAddDocumentCtx return value in rs_api (#1291) * check NewAddDocumentCtx ret val in rs_api (cherry picked from commit 3f89408) (cherry picked from commit 481ac38) * remove test from other pr not picked * skip on cluster * Update Clients.md (#1373) Add redisearch-api-rs (cherry picked from commit 5e0b66b) * fix -20* query (#1374) (cherry picked from commit 8a28d5c) * Fix issue 1414 remove hard limit on ft.search (#1416) * Fix issue 1414 remove hard limit on ft.search * add docs * print out unlimited (cherry picked from commit dcbbefc) * silence compiler (#1375) (#1418) (cherry picked from commit 2e171ae) Co-authored-by: Jake Angerman <kerneljake@users.noreply.github.com>
fix #1414