Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Time Series aggregator types #260

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

burmisov
Copy link
Contributor

Just noticed that some of the aggregator types are missing from the Aggregation selector.

Used this as a reference: https://redis.io/commands/ts.range/
Descriptions are taken straight from the official TS.RANGE command doc.

I've examined the code a bit and it seems like this is the only place that needs to be changed, but not 100% sure...

Thanks for an awesome plugin

@mikhail-vl
Copy link
Contributor

@burmisov Thanks for contribution. I have not tested it, but looks good to me.

I will let Redis team to follow-up.

@mipapo
Copy link

mipapo commented Feb 17, 2023

@burmisov How hard would it be to add the GROUPBY https://redis.io/commands/ts.mrange/?

Copy link
Contributor

@slorello89 slorello89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @burmisov - apologies for the delay - thank you for submitting this - tested it out in my deployment - LGMT 👍 - juggling some other bits but will merge when appropriate.

Thanks again!

@slorello89 slorello89 merged commit 72f4467 into RedisGrafana:master Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants