Move index iterator construction to first Consume call (#1169) #1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move index iterator construction to first Consume call * Address PR comments Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> (cherry picked from commit 7853153)
swilly22
approved these changes
Jul 9, 2020
DvirDukhan
added a commit
that referenced
this pull request
Jul 12, 2020
* Move index iterator construction to first Consume call * Address PR comments Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> (cherry picked from commit 7853153) Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com> Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>
swilly22
added a commit
that referenced
this pull request
Jul 12, 2020
* Add suppression for erroneous leak reports after DEBUG RELOAD (#1094) (#1210) (cherry picked from commit 386a8e6) Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com> * Update value.c (#1209) removed.boolean switch (cherry picked from commit e5ab233) Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> * LabelScan with child reads data correctly after reset (#1086) (#1207) (cherry picked from commit cce2ebb) Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com> Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> * Error properly on graph accesses of non-graph keys (#1069) (#1206) * Error properly on graph accesses of non-graph keys * Explicitly free QueryCtx on failed delete * Update cmd_delete.c Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> (cherry picked from commit 0cf50df) Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com> Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> * make memcheck rule prints full log for files with leaks (#1072) (#1205) Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> (cherry picked from commit 135e0bc) Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com> Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> * ReduceScan and ReduceTraversal respect variable scopes (#1070) (#1204) * ReduceScan and ReduceTraversal respect variable scopes * Fix source lookup * PR fixes Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> (cherry picked from commit 29b75d8) Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com> Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> * Better compile-time checking for undefined variables (#1063) (#1203) * Improve AST validations to capture undefined variables * Propagate errors in nested AR_EXP_Evaluate failures (cherry picked from commit e62b823) Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com> Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> * add cloud link and NOT conditions unary validation (#1214) * Guarantee that NOT conditions are unary (#1092) (#1208) (cherry picked from commit b56f98a) Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com> Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> * link to redis cloud Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com> Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> Co-authored-by: Pieter Cailliau <pieter.cailliau@gmail.com> * Bidirectional expand into (#1047) * wip * Remove unnecessary iterator * WIP * Fix bidirectional ExpandInto, shared edge populating logic * PR fixes * Post-rebase fixes * Fix PR comments (cherry picked from commit d46c6b6) * Skip NULL-valued properties in bulk loader (#1108) * Skip NULL-valued properties in bulk loader * Address PR comment, add missing logic in edge procesing (cherry picked from commit b62e802) * do not propagate transpose effect when introducing a transpose operation, maintain expression structure (#1102) (cherry picked from commit d6d6f8b) * added params support to id seek (#1164) (#1218) * added params support to id seek * reduce to scalar with runtime * fixed PR comments * fixed PR comments (cherry picked from commit bc609c3) * Move index iterator construction to first Consume call (#1169) (#1219) * Move index iterator construction to first Consume call * Address PR comments Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> (cherry picked from commit 7853153) Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com> Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com> Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> Co-authored-by: Pieter Cailliau <pieter.cailliau@gmail.com>
DvirDukhan
added a commit
that referenced
this pull request
Jul 13, 2020
* Move index iterator construction to first Consume call * Address PR comments Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> (cherry picked from commit 7853153) Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com> Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>
DvirDukhan
added a commit
that referenced
this pull request
Jul 13, 2020
* Add suppression for erroneous leak reports after DEBUG RELOAD (#1094) (#1210) (cherry picked from commit 386a8e6) Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com> * Update value.c (#1209) removed.boolean switch (cherry picked from commit e5ab233) Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> * LabelScan with child reads data correctly after reset (#1086) (#1207) (cherry picked from commit cce2ebb) Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com> Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> * Error properly on graph accesses of non-graph keys (#1069) (#1206) * Error properly on graph accesses of non-graph keys * Explicitly free QueryCtx on failed delete * Update cmd_delete.c Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> (cherry picked from commit 0cf50df) Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com> Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> * make memcheck rule prints full log for files with leaks (#1072) (#1205) Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> (cherry picked from commit 135e0bc) Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com> Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> * ReduceScan and ReduceTraversal respect variable scopes (#1070) (#1204) * ReduceScan and ReduceTraversal respect variable scopes * Fix source lookup * PR fixes Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> (cherry picked from commit 29b75d8) Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com> Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> * Better compile-time checking for undefined variables (#1063) (#1203) * Improve AST validations to capture undefined variables * Propagate errors in nested AR_EXP_Evaluate failures (cherry picked from commit e62b823) Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com> Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> * add cloud link and NOT conditions unary validation (#1214) * Guarantee that NOT conditions are unary (#1092) (#1208) (cherry picked from commit b56f98a) Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com> Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> * link to redis cloud Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com> Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> Co-authored-by: Pieter Cailliau <pieter.cailliau@gmail.com> * Bidirectional expand into (#1047) * wip * Remove unnecessary iterator * WIP * Fix bidirectional ExpandInto, shared edge populating logic * PR fixes * Post-rebase fixes * Fix PR comments (cherry picked from commit d46c6b6) * Skip NULL-valued properties in bulk loader (#1108) * Skip NULL-valued properties in bulk loader * Address PR comment, add missing logic in edge procesing (cherry picked from commit b62e802) * do not propagate transpose effect when introducing a transpose operation, maintain expression structure (#1102) (cherry picked from commit d6d6f8b) * added params support to id seek (#1164) (#1218) * added params support to id seek * reduce to scalar with runtime * fixed PR comments * fixed PR comments (cherry picked from commit bc609c3) * Move index iterator construction to first Consume call (#1169) (#1219) * Move index iterator construction to first Consume call * Address PR comments Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> (cherry picked from commit 7853153) Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com> Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com> Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> Co-authored-by: Pieter Cailliau <pieter.cailliau@gmail.com>
DvirDukhan
added a commit
that referenced
this pull request
Jul 15, 2020
* Add suppression for erroneous leak reports after DEBUG RELOAD (#1094) (#1210) (cherry picked from commit 386a8e6) Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com> * Update value.c (#1209) removed.boolean switch (cherry picked from commit e5ab233) Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> * LabelScan with child reads data correctly after reset (#1086) (#1207) (cherry picked from commit cce2ebb) Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com> Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> * Error properly on graph accesses of non-graph keys (#1069) (#1206) * Error properly on graph accesses of non-graph keys * Explicitly free QueryCtx on failed delete * Update cmd_delete.c Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> (cherry picked from commit 0cf50df) Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com> Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> * make memcheck rule prints full log for files with leaks (#1072) (#1205) Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> (cherry picked from commit 135e0bc) Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com> Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> * ReduceScan and ReduceTraversal respect variable scopes (#1070) (#1204) * ReduceScan and ReduceTraversal respect variable scopes * Fix source lookup * PR fixes Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> (cherry picked from commit 29b75d8) Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com> Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> * Better compile-time checking for undefined variables (#1063) (#1203) * Improve AST validations to capture undefined variables * Propagate errors in nested AR_EXP_Evaluate failures (cherry picked from commit e62b823) Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com> Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> * add cloud link and NOT conditions unary validation (#1214) * Guarantee that NOT conditions are unary (#1092) (#1208) (cherry picked from commit b56f98a) Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com> Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> * link to redis cloud Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com> Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> Co-authored-by: Pieter Cailliau <pieter.cailliau@gmail.com> * Bidirectional expand into (#1047) * wip * Remove unnecessary iterator * WIP * Fix bidirectional ExpandInto, shared edge populating logic * PR fixes * Post-rebase fixes * Fix PR comments (cherry picked from commit d46c6b6) * Skip NULL-valued properties in bulk loader (#1108) * Skip NULL-valued properties in bulk loader * Address PR comment, add missing logic in edge procesing (cherry picked from commit b62e802) * do not propagate transpose effect when introducing a transpose operation, maintain expression structure (#1102) (cherry picked from commit d6d6f8b) * added params support to id seek (#1164) (#1218) * added params support to id seek * reduce to scalar with runtime * fixed PR comments * fixed PR comments (cherry picked from commit bc609c3) * Move index iterator construction to first Consume call (#1169) (#1219) * Move index iterator construction to first Consume call * Address PR comments Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> (cherry picked from commit 7853153) Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com> Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com> Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> Co-authored-by: Pieter Cailliau <pieter.cailliau@gmail.com>
swilly22
added a commit
that referenced
this pull request
Jul 15, 2020
* Resolve race in accessing/updating attribute maps (#1165) (#1223) * Protect critical region of reading/updating GraphContext attributes * Improve lock coverage * Don't heap-alloc attribute ID values * Change to QueryCtx lock check * Bulk insert deadlock fix * Remove FindOrAddAttribute calls from critical region * Revert changes to QueryCtx * Revert changes to Graph * Introduce new rwlock for attribute mapping * Only lookup property ID once * Fix unit tests * Fix possible duplicate entry * Always retrieve attribute value in critical region * Address PR comments * Address PR comments Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> (cherry picked from commit d66affb) * Add suppression for erroneous leak reports after DEBUG RELOAD (#1094) (#1210) (cherry picked from commit 386a8e6) Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com> * Update value.c (#1209) removed.boolean switch (cherry picked from commit e5ab233) Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> * LabelScan with child reads data correctly after reset (#1086) (#1207) (cherry picked from commit cce2ebb) Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com> Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> * Error properly on graph accesses of non-graph keys (#1069) (#1206) * Error properly on graph accesses of non-graph keys * Explicitly free QueryCtx on failed delete * Update cmd_delete.c Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> (cherry picked from commit 0cf50df) Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com> Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> * make memcheck rule prints full log for files with leaks (#1072) (#1205) Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> (cherry picked from commit 135e0bc) Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com> Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> * ReduceScan and ReduceTraversal respect variable scopes (#1070) (#1204) * ReduceScan and ReduceTraversal respect variable scopes * Fix source lookup * PR fixes Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> (cherry picked from commit 29b75d8) Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com> Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> * Better compile-time checking for undefined variables (#1063) (#1203) * Improve AST validations to capture undefined variables * Propagate errors in nested AR_EXP_Evaluate failures (cherry picked from commit e62b823) Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com> Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> * add cloud link and NOT conditions unary validation (#1214) * Guarantee that NOT conditions are unary (#1092) (#1208) (cherry picked from commit b56f98a) Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com> Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> * link to redis cloud Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com> Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> Co-authored-by: Pieter Cailliau <pieter.cailliau@gmail.com> * Bidirectional expand into (#1047) * wip * Remove unnecessary iterator * WIP * Fix bidirectional ExpandInto, shared edge populating logic * PR fixes * Post-rebase fixes * Fix PR comments (cherry picked from commit d46c6b6) * do not propagate transpose effect when introducing a transpose operation, maintain expression structure (#1102) (cherry picked from commit d6d6f8b) * added params support to id seek (#1164) (#1218) * added params support to id seek * reduce to scalar with runtime * fixed PR comments * fixed PR comments (cherry picked from commit bc609c3) * Skip NULL-valued properties in bulk loader (#1108) (#1216) * Add suppression for erroneous leak reports after DEBUG RELOAD (#1094) (#1210) (cherry picked from commit 386a8e6) Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com> * Update value.c (#1209) removed.boolean switch (cherry picked from commit e5ab233) Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> * LabelScan with child reads data correctly after reset (#1086) (#1207) (cherry picked from commit cce2ebb) Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com> Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> * Error properly on graph accesses of non-graph keys (#1069) (#1206) * Error properly on graph accesses of non-graph keys * Explicitly free QueryCtx on failed delete * Update cmd_delete.c Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> (cherry picked from commit 0cf50df) Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com> Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> * make memcheck rule prints full log for files with leaks (#1072) (#1205) Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> (cherry picked from commit 135e0bc) Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com> Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> * ReduceScan and ReduceTraversal respect variable scopes (#1070) (#1204) * ReduceScan and ReduceTraversal respect variable scopes * Fix source lookup * PR fixes Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> (cherry picked from commit 29b75d8) Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com> Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> * Better compile-time checking for undefined variables (#1063) (#1203) * Improve AST validations to capture undefined variables * Propagate errors in nested AR_EXP_Evaluate failures (cherry picked from commit e62b823) Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com> Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> * add cloud link and NOT conditions unary validation (#1214) * Guarantee that NOT conditions are unary (#1092) (#1208) (cherry picked from commit b56f98a) Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com> Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> * link to redis cloud Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com> Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> Co-authored-by: Pieter Cailliau <pieter.cailliau@gmail.com> * Bidirectional expand into (#1047) * wip * Remove unnecessary iterator * WIP * Fix bidirectional ExpandInto, shared edge populating logic * PR fixes * Post-rebase fixes * Fix PR comments (cherry picked from commit d46c6b6) * Skip NULL-valued properties in bulk loader (#1108) * Skip NULL-valued properties in bulk loader * Address PR comment, add missing logic in edge procesing (cherry picked from commit b62e802) * do not propagate transpose effect when introducing a transpose operation, maintain expression structure (#1102) (cherry picked from commit d6d6f8b) * added params support to id seek (#1164) (#1218) * added params support to id seek * reduce to scalar with runtime * fixed PR comments * fixed PR comments (cherry picked from commit bc609c3) * Move index iterator construction to first Consume call (#1169) (#1219) * Move index iterator construction to first Consume call * Address PR comments Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> (cherry picked from commit 7853153) Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com> Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com> Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> Co-authored-by: Pieter Cailliau <pieter.cailliau@gmail.com> * add GTM (#1237) (cherry picked from commit 8cc66d8) * fixed graph context creation * Update index on change (#1225) * WIP * Fix compile errors * Only update indexes when necessary * refined update entity update eval * WIP * WIP * Compilation fixes, edge updates * Add freeing logic * Update comments * some minor changes to op_update * Address PR comments * Address PR comments * always get updated node label id Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com> Co-authored-by: DvirDukhan <dvir@redislabs.com> (cherry picked from commit e712193) * Update index on change (#1225) * WIP * Fix compile errors * Only update indexes when necessary * refined update entity update eval * WIP * WIP * Compilation fixes, edge updates * Add freeing logic * Update comments * some minor changes to op_update * Address PR comments * Address PR comments * always get updated node label id Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com> Co-authored-by: DvirDukhan <dvir@redislabs.com> (cherry picked from commit e712193) * memceck race handling (#1152) * removed time.sleep from tests teardown * added async delete config * fixed config and makefile * moved memcheck to compiler flag (cherry picked from commit b7d0a38) Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com> Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> Co-authored-by: Pieter Cailliau <pieter.cailliau@gmail.com> Co-authored-by: Guy Korland <gkorland@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move index iterator construction to first Consume call
Address PR comments
Co-authored-by: Roi Lipman swilly22@users.noreply.github.com
(cherry picked from commit 7853153)