Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-arrays get cleared too #65

Merged
merged 3 commits into from
Jan 30, 2022
Merged

Conversation

sazzad16
Copy link
Collaborator

No description provided.

@gkorland
Copy link
Contributor

gkorland commented Jan 30, 2022

@sazzad16 we shouldn't remove the test but adopt it to the right result.

        Path strPath = Path.of("foo");
        assertEquals(3L, client.clear("foobar", strPath));
        assertEquals("", client.get("foobar", String.class, strPath));

@gkorland gkorland self-requested a review January 30, 2022 21:33
@gkorland gkorland merged commit 4858eea into RedisJSON:master Jan 30, 2022
@sazzad16 sazzad16 deleted the non-array-clear branch January 31, 2022 00:47
@sazzad16
Copy link
Collaborator Author

@gkorland Thank you for handling that.

sazzad16 added a commit that referenced this pull request May 17, 2022
sazzad16 added a commit that referenced this pull request May 17, 2022
sazzad16 added a commit to sazzad16/jedis that referenced this pull request May 17, 2022
sazzad16 added a commit to redis/jedis that referenced this pull request May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants