Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid c++11 nullptr and use 0 on null comparison #236

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Conversation

filipecosta90
Copy link
Collaborator

Fixes #235

nullptr was introduced in c++11 and if your compiler does not support it will happen the error of #235 . This PR addresses it.

Reference: https://www.stroustrup.com/bs_faq2.html#null

@filipecosta90 filipecosta90 changed the title avoid c++11 nullptr and use 0 on null comparison Avoid c++11 nullptr and use 0 on null comparison Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #236 (1706538) into master (bec3471) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 1706538 differs from pull request most recent head d06d9ab. Consider uploading reports for the commit d06d9ab to get more accurate results

@@           Coverage Diff           @@
##           master     #236   +/-   ##
=======================================
  Coverage   56.41%   56.41%           
=======================================
  Files          21       21           
  Lines        4359     4359           
=======================================
  Hits         2459     2459           
  Misses       1900     1900           
Files Changed Coverage Δ
memtier_benchmark.cpp 53.81% <100.00%> (ø)

@filipecosta90 filipecosta90 merged commit 0325e00 into master Oct 16, 2023
8 checks passed
@filipecosta90 filipecosta90 deleted the fix.nullptr branch October 16, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error reported when executing command 'make'
2 participants