Issue 207: Add Sentinels support for spark-redis library #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gkorland @fe2s Please check this PR, also jedis version updated to 3.3.0 as in 3.2.0 there is a critical auth issue redis/jedis#2154 |
fe2s
reviewed
Jun 9, 2020
| * @param schema Current schema | ||
| * @param requiredColumns Column positions expecting by Catalyst | ||
| */ | ||
| def alignSchemaWithCatalyst(schema: StructType, requiredColumns: Seq[String]): StructType = { |
There was a problem hiding this comment.
Looks like these changes are not related to Sentinels support. Could you please create a separate PR for that?
This reverts commit b66a30c
|
any updates on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding sentinel support. This is working solution, we badly needed sentinels for our use case. WIth this fix its working in our organization