#304: added toRedisByteHASHes function #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .map { case (key, hashFields) => | ||
| (redisConfig.getHost(key), (key, hashFields)) | ||
| } | ||
| .toArray |
There was a problem hiding this comment.
We take in an Iterator, but here we are materializing it in one go with .toArray. This could cause OOM. Can we work in batches using .grouped(SOME_BATCH_SIZE) and do all the subsequent things per batch?
There was a problem hiding this comment.
Hi @mayankasthana ,
Thank you for the comment, good point. We do grouping when writing dataframe in RedisSourceRelation, but it's missing in all RDD write functions. I'll fix that.
|
Hey guys, just wanted to check if these changes were reviewed and if it could be merged. |
gkorland
approved these changes
Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.