Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++ RedisModule API #59

Draft
wants to merge 31 commits into
base: master
Choose a base branch
from
Draft

C++ RedisModule API #59

wants to merge 31 commits into from

Conversation

rafie
Copy link
Contributor

@rafie rafie commented Aug 5, 2022 •
edited by ephraimfeldblum
Loading

rafie and others added 30 commits August 2, 2022 10:19
@rafie
C++ RedisModule API
6acb933
@ephraimfeldblum
4/8/22
25c4591
@ephraimfeldblum
morning 7/8/22
18c9585
@ephraimfeldblum
7/8/22
894e416
@ephraimfeldblum
morning 8/8/22
7f70211
@ephraimfeldblum
lunch 8/8/22
09c4569
@ephraimfeldblum
interrogating exceptions
d2d8cf0
@rafie
Added 7.0 & unstable APIs
156f14b
@rafie
Fix to 7.0 API
6996758
@ephraimfeldblum
EoD 10/8/22 pain and despair
c728eb4
@ephraimfeldblum
noon 11/8/22
d624e8b
@ephraimfeldblum
11/8/22 nearly EoD. frustrated with forwarding
83383b0
@ephraimfeldblum
why are there so many opaque structs that are unconstructable? how ar…
8bb52de 
…e we meant to use them in this API?
@ephraimfeldblum
need to rethink string::operator=
bda37fb
@ephraimfeldblum
CallReply blood magic needs to be thought through thoroughly
9554c98
@ephraimfeldblum
cxx module compiles
e1131de
@ephraimfeldblum
but fails to load. out to lunch.
27c696a
@ephraimfeldblum
#ifdef __cplusplus extern C. as and where relevant
1febd88
@ephraimfeldblum
minor
d20e8e5
@ephraimfeldblum
example passed. still far from complete though
ccf8ba1
@ephraimfeldblum
unwrapping cppclasses to cstruct*s using cpp20 concepts
f055505
@ephraimfeldblum
unwrapping cppclasses to cstruct*s using cpp20 concepts
7e7c349
@ephraimfeldblum
slightly more readable: less declval, more auto
b9d077b
@ephraimfeldblum
no owned strings, only retained refs
19d0ae5
@ephraimfeldblum
passing responsibility to std::unique_ptr where appropriate
60f2f9f
@ephraimfeldblum
simplifying ownership
880f6d1
@ephraimfeldblum
encapsulating deleters
87b9d89
@ephraimfeldblum
added some missing functionality. added class Context. moved BlockCli…
13d8695 
…ent() and Call() to Context; made BlockedClient and CallReply's ctors private.
@ephraimfeldblum
callbacks working. just needed to use template parameters.
8bbb1a5
@ephraimfeldblum
CRTP should be CRTP. No virtual functions, that way lies madness. Arg…
93a21f4 
…s now contains a span, however it found it; be it raw ptr, std::vector, etc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rafie @ephraimfeldblum