use RedisModuleDict instead linked list #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danni-m
reviewed
Nov 13, 2018
src/tsdb.c
Outdated
| return sizeof(series) + sizeof(Chunk) * RedisModule_DictSize(series->chunks); | ||
| } | ||
|
|
||
| Chunk *SeriesGetLastChunk(Series *series) |
There was a problem hiding this comment.
@yaeltzirulnikov whats the complexity for this function?
this has influence on ts.add complexity, we might want to "cache" the pointer to the last pointer.
src/tsdb.h
Outdated
| int32_t retentionSecs; | ||
| short maxSamplesPerChunk; | ||
| CompactionRule *rules; | ||
| timestamp_t lastTimestamp; | ||
| double lastValue; | ||
| RedisModuleCtx *ctx; |
There was a problem hiding this comment.
@yaeltzirulnikov dead code?
src/tsdb.c
Outdated
| @@ -95,7 +116,8 @@ int SeriesAddSample(Series *series, api_timestamp_t timestamp, double value) { | |||
| SeriesIterator SeriesQuery(Series *series, api_timestamp_t minTimestamp, api_timestamp_t maxTimestamp) { | |||
| SeriesIterator iter; | |||
| iter.series = series; | |||
| iter.currentChunk = series->firstChunk; | |||
| iter.dictIter = RedisModule_DictIteratorStartC(series->chunks, "^", NULL, 0); | |||
There was a problem hiding this comment.
This means we search from the beginning?
yaeltzirulnikov
force-pushed
the
yael-use_rax_instead_linked_list
branch
3 times, most recently
from
9988a35
to
ee3ed0d
Compare
danni-m
reviewed
Nov 14, 2018
danni-m
reviewed
Nov 14, 2018
danni-m
reviewed
Nov 14, 2018
yaeltzirulnikov
force-pushed
the
yael-use_rax_instead_linked_list
branch
from
ee3ed0d
to
2248b4c
Compare
danni-m
approved these changes
Nov 14, 2018
rafie
added a commit
that referenced
this pull request
Jul 3, 2019
rafie
added a commit
that referenced
this pull request
Sep 4, 2019
rafie
added a commit
that referenced
this pull request
Sep 5, 2019
rafie
added a commit
that referenced
this pull request
Sep 5, 2019
* CircleCI: build multiarch docker image * CircleCI: build multiarch docker image #2 * CircleCI: build multiarch docker image #3 * CircleCI: build multiarch docker image #4 * CircleCI: build multiarch docker image #5 * CircleCI: build multiarch docker image #6 * CircleCI: build multiarch docker image #7 * CircleCI: build multiarch docker image #8 * CircleCI: build multiarch docker image #9 * CircleCI: build multiarch docker image #10 * CircleCI: build multiarch docker image #11 * CircleCI: build multiarch docker image #12 * CircleCI: build multiarch docker image #13 * CircleCI: build multiarch docker image #14 * CircleCI: build multiarch docker image #15 * CircleCI: build multiarch docker image #16 * CircleCI: build multiarch docker image #17 * CircleCI: build multiarch docker image #18 * CircleCI: build multiarch docker image #19 * CircleCI: build multiarch docker image #20 * CircleCI: build multiarch docker image #21 * CircleCI: build multiarch docker image #22 * CircleCI: build multiarch docker image #23 * CircleCI: build multiarch docker image #24 * CircleCI: build multiarch docker image #25 * CircleCI: build multiarch docker image #26 * CircleCI: build multiarch docker image #27 * CircleCI: build multiarch docker image #28 * CircleCI: build multiarch docker image * CircleCI: build multiarch docker image #2 * CircleCI: build multiarch docker image #3 * CircleCI: build multiarch docker image #4 * CircleCI: build multiarch docker image #5 * CircleCI: build multiarch docker image #6 * CircleCI: build multiarch docker image #7 * CircleCI: build multiarch docker image #8 * CircleCI: build multiarch docker image #9 * CircleCI: build multiarch docker image #10 * CircleCI: build multiarch docker image #11 * CircleCI: build multiarch docker image #12 * CircleCI: build multiarch docker image #13 * CircleCI: build multiarch docker image #14 * CircleCI: build multiarch docker image #15 * CircleCI: build multiarch docker image #16 * CircleCI: build multiarch docker image #17 * CircleCI: build multiarch docker image #18 * CircleCI: build multiarch docker image #19 * CircleCI: build multiarch docker image #20 * CircleCI: build multiarch docker image #21 * CircleCI: build multiarch docker image #22 * CircleCI: build multiarch docker image #23 * CircleCI: build multiarch docker image #24 * CircleCI: build multiarch docker image #25 * CircleCI: build multiarch docker image #26 * CircleCI: build multiarch docker image #27 * CircleCI: build multiarch docker image #28 * Readies sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.