RED-21500: Support automatic timestamps using ts.add key * value #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
yaeltzirulnikov
force-pushed
the
yael-support_automatic_timestamps
branch
from
01e0017
to
d9d1870
Compare
danni-m
reviewed
Aug 18, 2018
src/module.c
Outdated
| @@ -186,11 +186,14 @@ int TSDB_add(RedisModuleCtx *ctx, RedisModuleString **argv, int argc) { | |||
| RedisModuleKey *key = RedisModule_OpenKey(ctx, keyName, REDISMODULE_READ|REDISMODULE_WRITE); | |||
|
|
|||
| double timestamp, value; | |||
| RedisModuleString* automaticTimestamp = RedisModule_CreateStringPrintf(ctx, "*"); | |||
There was a problem hiding this comment.
@yaeltzirulnikov using RedisModule_CreateStringPrintf is not very optimal, please check the RedisModule's API to see if you can compare strings without allocating every time TSDB_add is called.
yaeltzirulnikov
force-pushed
the
yael-support_automatic_timestamps
branch
from
d9d1870
to
3794b5f
Compare
danni-m
approved these changes
Aug 28, 2018
rafie
added a commit
that referenced
this pull request
Jun 11, 2019
rafie
added a commit
that referenced
this pull request
Jun 26, 2019
rafie
added a commit
that referenced
this pull request
Jul 2, 2019
rafie
added a commit
that referenced
this pull request
Jul 2, 2019
rafie
added a commit
that referenced
this pull request
Sep 3, 2019
rafie
added a commit
that referenced
this pull request
Sep 5, 2019
rafie
added a commit
that referenced
this pull request
Sep 5, 2019
* CircleCI: build multiarch docker image * CircleCI: build multiarch docker image #2 * CircleCI: build multiarch docker image #3 * CircleCI: build multiarch docker image #4 * CircleCI: build multiarch docker image #5 * CircleCI: build multiarch docker image #6 * CircleCI: build multiarch docker image #7 * CircleCI: build multiarch docker image #8 * CircleCI: build multiarch docker image #9 * CircleCI: build multiarch docker image #10 * CircleCI: build multiarch docker image #11 * CircleCI: build multiarch docker image #12 * CircleCI: build multiarch docker image #13 * CircleCI: build multiarch docker image #14 * CircleCI: build multiarch docker image #15 * CircleCI: build multiarch docker image #16 * CircleCI: build multiarch docker image #17 * CircleCI: build multiarch docker image #18 * CircleCI: build multiarch docker image #19 * CircleCI: build multiarch docker image #20 * CircleCI: build multiarch docker image #21 * CircleCI: build multiarch docker image #22 * CircleCI: build multiarch docker image #23 * CircleCI: build multiarch docker image #24 * CircleCI: build multiarch docker image #25 * CircleCI: build multiarch docker image #26 * CircleCI: build multiarch docker image #27 * CircleCI: build multiarch docker image #28 * CircleCI: build multiarch docker image * CircleCI: build multiarch docker image #2 * CircleCI: build multiarch docker image #3 * CircleCI: build multiarch docker image #4 * CircleCI: build multiarch docker image #5 * CircleCI: build multiarch docker image #6 * CircleCI: build multiarch docker image #7 * CircleCI: build multiarch docker image #8 * CircleCI: build multiarch docker image #9 * CircleCI: build multiarch docker image #10 * CircleCI: build multiarch docker image #11 * CircleCI: build multiarch docker image #12 * CircleCI: build multiarch docker image #13 * CircleCI: build multiarch docker image #14 * CircleCI: build multiarch docker image #15 * CircleCI: build multiarch docker image #16 * CircleCI: build multiarch docker image #17 * CircleCI: build multiarch docker image #18 * CircleCI: build multiarch docker image #19 * CircleCI: build multiarch docker image #20 * CircleCI: build multiarch docker image #21 * CircleCI: build multiarch docker image #22 * CircleCI: build multiarch docker image #23 * CircleCI: build multiarch docker image #24 * CircleCI: build multiarch docker image #25 * CircleCI: build multiarch docker image #26 * CircleCI: build multiarch docker image #27 * CircleCI: build multiarch docker image #28 * Readies sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.