Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some data missing after server restart #23

Closed
gacha opened this issue Dec 8, 2018 · 4 comments
Closed

some data missing after server restart #23

gacha opened this issue Dec 8, 2018 · 4 comments
Assignees
Projects

Comments

@gacha
Copy link

gacha commented Dec 8, 2018

Hi,

so I create a TS list TS.CREATE temp and then with a script I insert each 5 minutes a reading (0..30) for one year - 105120 in total. I insert the same data in a sorted set ztemp. The result is as follows:

127.0.0.1:6379> TS.INFO temp
 1) lastTimestamp
 2) (integer) 1544309769
 3) retentionSecs
 4) (integer) 0
 5) chunkCount
 6) (integer) 292
 7) maxSamplesPerChunk
 8) (integer) 360
 9) rules
10) (empty list or set)
127.0.0.1:6379> ZCARD ztemp
(integer) 105120
127.0.0.1:6379> DEBUG OBJECT temp
Value at:0x7fa72d066730 refcount:1 encoding:raw serializedlength:1576823 lru:806228 lru_seconds_idle:71
127.0.0.1:6379> DEBUG OBJECT ztemp
Value at:0x7fa72d066720 refcount:1 encoding:skiplist serializedlength:5746654 lru:806255 lru_seconds_idle:48

then I save the db SAVE and restart the server. After that the result is as follows:

127.0.0.1:6379> TS.INFO temp
 1) lastTimestamp
 2) (integer) 1544309769
 3) retentionSecs
 4) (integer) 0
 5) chunkCount
 6) (integer) 8
 7) maxSamplesPerChunk
 8) (integer) 360
 9) rules
10) (empty list or set)
127.0.0.1:6379> ZCARD ztemp
(integer) 105120
127.0.0.1:6379> DEBUG OBJECT temp
Value at:0x7f899ac66840 refcount:1 encoding:raw serializedlength:43220 lru:806313 lru_seconds_idle:13
127.0.0.1:6379> DEBUG OBJECT ztemp
Value at:0x7f899ac66730 refcount:1 encoding:skiplist serializedlength:5746654 lru:806313 lru_seconds_idle:6

After restart the temp list has only 8 chunks and the serialized length is very small. The ztemp has the same size as before restart.

My redis server information:

redis-server -v
Redis server v=5.0.2 sha=00000000:0 malloc=jemalloc-5.1.0 bits=64 build=d7cfa2a01a7adee9

loadmodule /home/gatis/Apps/redis/redis-tsdb-module.so
dir /home/gatis/Apps/redis/db
logfile /home/gatis/Apps/redis/redis.log
loglevel debug
@gacha
Copy link
Author

gacha commented Dec 18, 2018

I tested the same on a different machine and the problem was the same, just the chunkCount was 6. Is this normal behavior or I misunderstood something?

@danni-m
Copy link
Collaborator

danni-m commented Dec 18, 2018

@gacha looks like a bug, the following is the expected behivor:

  1. have x samples in ztemp
  2. save
  3. restart
  4. read ztemp -> expected is x samples

@danni-m
Copy link
Collaborator

danni-m commented Dec 19, 2018

@gacha I fixed the issue in the labels branch. im planning on merging it soon (need to finish documentation).

danni-m added a commit that referenced this issue Dec 19, 2018
@gacha
Copy link
Author

gacha commented Dec 20, 2018

Tested the labels branch and now TS.INFO shows the same before and after save&restart.

Thanks.

@gacha gacha closed this as completed Dec 20, 2018
danni-m added a commit that referenced this issue Jan 24, 2019
* Add labels to keys and support it when querying
* Timestamps changes: use u_int64_t for both apit_timestamp_t and timestamp_t

* fix #23: use String as RAX keys

* Update docs to reflect labels docs update
@gkorland gkorland added this to To do in 0.1.0 via automation Feb 17, 2019
@gkorland gkorland moved this from To do to Done in 0.1.0 Feb 17, 2019
rafie added a commit that referenced this issue Sep 4, 2019
rafie added a commit that referenced this issue Sep 5, 2019
rafie added a commit that referenced this issue Sep 5, 2019
* CircleCI: build multiarch docker image

* CircleCI: build multiarch docker image #2

* CircleCI: build multiarch docker image #3

* CircleCI: build multiarch docker image #4

* CircleCI: build multiarch docker image #5

* CircleCI: build multiarch docker image #6

* CircleCI: build multiarch docker image #7

* CircleCI: build multiarch docker image #8

* CircleCI: build multiarch docker image #9

* CircleCI: build multiarch docker image #10

* CircleCI: build multiarch docker image #11

* CircleCI: build multiarch docker image #12

* CircleCI: build multiarch docker image #13

* CircleCI: build multiarch docker image #14

* CircleCI: build multiarch docker image #15

* CircleCI: build multiarch docker image #16

* CircleCI: build multiarch docker image #17

* CircleCI: build multiarch docker image #18

* CircleCI: build multiarch docker image #19

* CircleCI: build multiarch docker image #20

* CircleCI: build multiarch docker image #21

* CircleCI: build multiarch docker image #22

* CircleCI: build multiarch docker image #23

* CircleCI: build multiarch docker image #24

* CircleCI: build multiarch docker image #25

* CircleCI: build multiarch docker image #26

* CircleCI: build multiarch docker image #27

* CircleCI: build multiarch docker image #28

* CircleCI: build multiarch docker image

* CircleCI: build multiarch docker image #2

* CircleCI: build multiarch docker image #3

* CircleCI: build multiarch docker image #4

* CircleCI: build multiarch docker image #5

* CircleCI: build multiarch docker image #6

* CircleCI: build multiarch docker image #7

* CircleCI: build multiarch docker image #8

* CircleCI: build multiarch docker image #9

* CircleCI: build multiarch docker image #10

* CircleCI: build multiarch docker image #11

* CircleCI: build multiarch docker image #12

* CircleCI: build multiarch docker image #13

* CircleCI: build multiarch docker image #14

* CircleCI: build multiarch docker image #15

* CircleCI: build multiarch docker image #16

* CircleCI: build multiarch docker image #17

* CircleCI: build multiarch docker image #18

* CircleCI: build multiarch docker image #19

* CircleCI: build multiarch docker image #20

* CircleCI: build multiarch docker image #21

* CircleCI: build multiarch docker image #22

* CircleCI: build multiarch docker image #23

* CircleCI: build multiarch docker image #24

* CircleCI: build multiarch docker image #25

* CircleCI: build multiarch docker image #26

* CircleCI: build multiarch docker image #27

* CircleCI: build multiarch docker image #28

* Readies sync
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
0.1.0
  
Done
Development

No branches or pull requests

2 participants