Labels support #22
Merged
Labels support #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ebylabels`, simpler index query logic
…fix strtok_r usage and rename vars
src/indexer.c
Outdated
| RedisModule_StringPtrLen(labels[i].value, &_s)); | ||
| RedisModuleString *indexed_key = RedisModule_CreateStringPrintf(ctx, "__index_%s", | ||
| RedisModule_StringPtrLen(labels[i].key, &_s), | ||
| RedisModule_StringPtrLen(labels[i].value, &_s)); |
There was a problem hiding this comment.
this line should be removed, only key is expected
There was a problem hiding this comment.
also, let's not call RedisModule_StringPtrLen(labels[i].key, &_s) twice
src/indexer.c
Outdated
| if (*lastKey == NULL) { | ||
| iter = RedisModule_DictIteratorStartC(left, "^", NULL, 0); | ||
| } else { | ||
| iter = RedisModule_DictIteratorStartC(left, "^", lastKey, *lastKeySize); |
There was a problem hiding this comment.
I'm not sure what this line is trying to do, but RedisModule_DictIteratorStartC with "^" ignores the given key
| } else if (predicate->type == EQ) { | ||
| return localResult; | ||
| } else { | ||
| return prevResults; |
There was a problem hiding this comment.
if you try to find all keys that don't match a label , and prevResults is NULL, this will return NULL instead of all the keys
| @@ -0,0 +1,184 @@ | |||
| #include <string.h> | |||
There was a problem hiding this comment.
please add documentation to indexer.c
| compactedLabels[i].key = RedisModule_CreateStringFromString(NULL, labels[i].key); | ||
| compactedLabels[i].value = RedisModule_CreateStringFromString(NULL, labels[i].value); | ||
| } | ||
|
|
There was a problem hiding this comment.
a comment explaining what we do here could be nice
… into labels # Conflicts: # README.md
rafie
added a commit
that referenced
this pull request
Sep 4, 2019
rafie
added a commit
that referenced
this pull request
Sep 5, 2019
rafie
added a commit
that referenced
this pull request
Sep 5, 2019
* CircleCI: build multiarch docker image * CircleCI: build multiarch docker image #2 * CircleCI: build multiarch docker image #3 * CircleCI: build multiarch docker image #4 * CircleCI: build multiarch docker image #5 * CircleCI: build multiarch docker image #6 * CircleCI: build multiarch docker image #7 * CircleCI: build multiarch docker image #8 * CircleCI: build multiarch docker image #9 * CircleCI: build multiarch docker image #10 * CircleCI: build multiarch docker image #11 * CircleCI: build multiarch docker image #12 * CircleCI: build multiarch docker image #13 * CircleCI: build multiarch docker image #14 * CircleCI: build multiarch docker image #15 * CircleCI: build multiarch docker image #16 * CircleCI: build multiarch docker image #17 * CircleCI: build multiarch docker image #18 * CircleCI: build multiarch docker image #19 * CircleCI: build multiarch docker image #20 * CircleCI: build multiarch docker image #21 * CircleCI: build multiarch docker image #22 * CircleCI: build multiarch docker image #23 * CircleCI: build multiarch docker image #24 * CircleCI: build multiarch docker image #25 * CircleCI: build multiarch docker image #26 * CircleCI: build multiarch docker image #27 * CircleCI: build multiarch docker image #28 * CircleCI: build multiarch docker image * CircleCI: build multiarch docker image #2 * CircleCI: build multiarch docker image #3 * CircleCI: build multiarch docker image #4 * CircleCI: build multiarch docker image #5 * CircleCI: build multiarch docker image #6 * CircleCI: build multiarch docker image #7 * CircleCI: build multiarch docker image #8 * CircleCI: build multiarch docker image #9 * CircleCI: build multiarch docker image #10 * CircleCI: build multiarch docker image #11 * CircleCI: build multiarch docker image #12 * CircleCI: build multiarch docker image #13 * CircleCI: build multiarch docker image #14 * CircleCI: build multiarch docker image #15 * CircleCI: build multiarch docker image #16 * CircleCI: build multiarch docker image #17 * CircleCI: build multiarch docker image #18 * CircleCI: build multiarch docker image #19 * CircleCI: build multiarch docker image #20 * CircleCI: build multiarch docker image #21 * CircleCI: build multiarch docker image #22 * CircleCI: build multiarch docker image #23 * CircleCI: build multiarch docker image #24 * CircleCI: build multiarch docker image #25 * CircleCI: build multiarch docker image #26 * CircleCI: build multiarch docker image #27 * CircleCI: build multiarch docker image #28 * Readies sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.